fix(viewerCrash): fix stdout/stderr for buffer OS#444
Closed
MaxNumerique wants to merge 1 commit into
Closed
Conversation
MaxNumerique
commented
Jun 26, 2026
| console.log(`[${child.name}] ${line}`); | ||
| recordOutput(line); | ||
| if (line.includes(expectedResponse)) { | ||
| cleanup(); |
Contributor
Author
There was a problem hiding this comment.
Dès que le viewer ou le backend écrivait plus de 64 Ko de logs (warnings de caméra, requêtes...), le buffer OS de son pipe saturait et le processus se bloquait indéfiniment sur son prochain log, provoquant des timeouts
Member
There was a problem hiding this comment.
@JulienChampagnol c'est toi qui a ajouté tout ca hier. Qu'en penses-tu ?
Contributor
Author
There was a problem hiding this comment.
C'est ça qui provoquait les crash. J'ai testé en local avec cleanup() je reproduisais le bug facilement. et du coup en l'enlevant ça ne crash plus, avec la même data ( 3000 corner, 2600 lines)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.