Skip to content

fix(viewerCrash): fix stdout/stderr for buffer OS #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxNumerique wants to merge 1 commit into from
Closed

fix(viewerCrash): fix stdout/stderr for buffer OS #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/utils/local/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ function waitForReady(child, expectedResponse, signal) {
console.log(`[${child.name}] ${line}`);
recordOutput(line);
if (line.includes(expectedResponse)) {
cleanup();

@MaxNumerique MaxNumerique Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dès que le viewer ou le backend écrivait plus de 64 Ko de logs (warnings de caméra, requêtes...), le buffer OS de son pipe saturait et le processus se bloquait indéfiniment sur son prochain log, provoquant des timeouts

@BotellaA BotellaA Jun 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JulienChampagnol c'est toi qui a ajouté tout ca hier. Qu'en penses-tu ?

@MaxNumerique MaxNumerique Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est ça qui provoquait les crash. J'ai testé en local avec cleanup() je reproduisais le bug facilement. et du coup en l'enlevant ça ne crash plus, avec la même data ( 3000 corner, 2600 lines)

resolve(child);
}
}
Expand Down
Loading