replace const ref with const value in FileSystem_impl::remove()

It may sometimes be permissible to assign the by-value result of a function to
a const reference, but in this case it was getting garbage data and causing the
filename check to fail.

(see Geontech/core-framework@30af902)

Signed-off-by: Thomas Goodwin <btgoodwin@geontech.com>

Author: Thomas Goodwin

recipes-core/core-framework/redhawk-2.2.3/filesystem_impl-const-value.patch

@@ -0,0 +1,13 @@
+Index: src/control/framework/FileSystem_impl.cpp
+===================================================================
+--- src.orig/control/framework/FileSystem_impl.cpp
++++ src/control/framework/FileSystem_impl.cpp
+@@ -177,7 +177,7 @@ void FileSystem_impl::remove (const char
+     
+     const fs::directory_iterator end_itr; // an end iterator (by boost definition)
+     for (fs::directory_iterator itr = fsops.begin(dirPath); itr != end_itr; fsops.increment(itr)) {
+-        const std::string& filename = BOOST_PATH_STRING(itr->path().filename());
++        const std::string filename = BOOST_PATH_STRING(itr->path().filename());
+         if (fnmatch(searchPattern.c_str(), filename.c_str(), 0) == 0) {
+             RH_TRACE(_fileSysLog, "Removing file " << itr->path().string());  
+             if (!fsops.remove(itr->path())) {

recipes-core/core-framework/redhawk_2.2.3.bb

@@ -65,6 +65,7 @@ SRC_URI_append = "\
     file://signalling.patch \
     file://dlopen_reverse_order.patch \
     file://bare-python2-references.patch \
+    file://filesystem_impl-const-value.patch \
 "
 
 S = "${WORKDIR}/git/redhawk/src"