Fix iterable sequence bug under unusual circumstances (#72)

Fixes #65

Author: George-Ogden

.github/workflows/test.yaml

@@ -21,7 +21,7 @@ jobs:
       pytest-flags: -vv mypy_pytest_plugin -n auto --shard-id=${{ matrix.shard }} --num-shards=${{ matrix.total-shards }} --inline-snapshot=disable
 
   integration_tests:
-    uses: George-Ogden/actions/.github/workflows/python-test.yaml@v4.0.2
+    uses: George-Ogden/actions/.github/workflows/python-test.yaml@v4.3.0
     with:
       python-versions: "['3.12', '3.13', '3.14']"
       timeout-minutes: 10

.mirror.lock

@@ -1,5 +1,5 @@
 # DANGER: EDIT AT YOUR OWN RISK. Track this file in version control so that others can sync files correctly.
-- commit: 7193772bffc9c387e2ba0c271cdf27b592ddd21f
+- commit: ef96ade262662786dd73eee856f6b20de499529e
   files:
   - .github/python-release.yaml
   - .github/python-test.yaml

.pre-commit-config.yaml

@@ -40,7 +40,7 @@ repos:
         args: [--severity=warning]
 
   - repo: https://github.com/astral-sh/ruff-pre-commit/
-    rev: v0.15.10
+    rev: v0.15.11
     hooks:
       - id: ruff-check
         args: [--fix]
@@ -64,7 +64,7 @@ repos:
       - id: codespell
 
   - repo: https://github.com/George-Ogden/pre-commit-hooks/
-    rev: v3.1.0
+    rev: v3.1.1
     hooks:
       - id: check-merge-conflict
       - id: dbg-check

mypy_pytest_plugin/iterable_sequence_checker.py

@@ -36,8 +36,12 @@ def check_iterable_sequence_arguments(self, call: CallExpr) -> None:
             self.check_iterable_sequence_argument(argument, expected_type)
 
     def check_iterable_sequence_argument(self, argument: Expression, expected_type: Type) -> None:
-        argument_type = self.checker.lookup_type(argument)
-        if self.is_sequence(argument_type) and self.is_iterable(expected_type):
+        argument_type = self.checker.lookup_type_or_none(argument)
+        if (
+            argument_type is not None
+            and self.is_sequence(argument_type)
+            and self.is_iterable(expected_type)
+        ):
             self._display_error_message(expected_type, argument_type, argument)
 
     def _display_error_message(

requirements-dev.txt

@@ -1,12 +1,13 @@
 -r requirements.txt
-georges-utils
+git+https://github.com/George-Ogden/extra-types; python_version >= "3.12"
 git+https://github.com/George-Ogden/mirror-rorrim; python_version >= "3.12"
 git+https://github.com/George-Ogden/pytest-dbg; python_version >= "3.11"
+git+https://github.com/George-Ogden/utils; python_version >= "3.12"
 inline-snapshot
 prek
 py-spy
 pytest>=9.0.0
 pytest-shard
 pytest-timeout
 pytest-xdist
-ruff==0.15.10
+ruff==0.15.11

ruff.toml

@@ -8,7 +8,7 @@ indent-style = "space"
 exclude = ["test_samples/"]
 extend-select = ["B", "C4", "COM818", "ERA", "F", "I", "ISC", "N", "PT", "PYI", "RET", "RUF", "SIM", "UP", "W"]
 extend-ignore = ["C408", "E501", "F811", "PLC0414", "PT011", "PT012", "PT013", "PYI041", "RET504", "S", "SIM118", "TRY"]
-extend-unfixable = ["B905", "B911", "B912"]
+extend-unfixable = ["B905", "B911", "B912", "PT006"]
 preview = true
 
 [lint.isort]

test_samples/valid_test.py

@@ -1,7 +1,8 @@
+from collections.abc import Callable, Iterable, Sequence
 from typing import Literal
-from pytest import CaptureFixture, Pytester
 
 import pytest
+from pytest import CaptureFixture, Pytester
 
 
 @pytest.mark.parametrize("x", range(5))
@@ -42,3 +43,10 @@ def test_use_builtin_fixture(capsys: CaptureFixture[str]) -> None: ...
 
 @pytest.mark.skip
 def test_pytester_fixture(pytester: Pytester) -> None: ...
+
+
+def test_range_argument() -> None:
+    def cached_iterator[**P, T](fn: Callable[P, Iterable[T]]) -> Callable[P, Sequence[T]]:
+        raise NotImplementedError()
+
+    cached_iterator(range)

tests/snapshots/test_samples/valid_test.txt

@@ -1,6 +1,6 @@
-test_samples/valid_test.py:14: error: Incompatible return value type (got "tuple[Literal[0], Literal[2]]", expected "tuple[Literal[1], Literal[2]]")  [return-value]
-test_samples/valid_test.py:17: error: Unexpected keyword argument "foo" for "param"  [call-arg]
-test_samples/valid_test.py:17: note: "param" defined in "mypy_pytest_plugin_types.pytest"
-test_samples/valid_test.py:20: error: No return value expected  [return-value]
-test_samples/valid_test.py:26: error: No return value expected  [return-value]
+test_samples/valid_test.py:15: error: Incompatible return value type (got "tuple[Literal[0], Literal[2]]", expected "tuple[Literal[1], Literal[2]]")  [return-value]
+test_samples/valid_test.py:18: error: Unexpected keyword argument "foo" for "param"  [call-arg]
+test_samples/valid_test.py:18: note: "param" defined in "mypy_pytest_plugin_types.pytest"
+test_samples/valid_test.py:21: error: No return value expected  [return-value]
+test_samples/valid_test.py:27: error: No return value expected  [return-value]
 Found 4 errors in 1 file (checked 1 source file)

version.txt

@@ -1 +1 @@
-2.3.2
+2.3.3