fix: trim search input value and update license#137
Open
Sigmabrogz wants to merge 1 commit into
Open
Conversation
Closes GeorgeHop#131 Closes GeorgeHop#122 - Applies `.trim()` to the search value and search dial code before filtering countries, fixing search matching when leading/trailing spaces exist. - Updates `package.json` license from ISC to MIT to match the LICENSE file.
Author
|
Hi, the PR is ready for review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two minor issues. It trims the search value to prevent lookup failures caused by accidental trailing or leading spaces, and updates the package.json license field to reflect the actual MIT license.
Problem
Closes #131
Closes #122
Solution
.trim()to the lowercase search value and dial code check in both filter locations."license": "ISC"to"license": "MIT"in package.json to match theLICENSEfile.Checklist