Skip to content

fix: trim search input value and update license #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sigmabrogz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: trim search input value and update license #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,11 @@ export const CountryPicker = ({
}, [showOnly, excludedCountries, lang]);

const resultCountries = React.useMemo(() => {
const lowerSearchValue = searchValue.toLowerCase();
const lowerSearchValue = searchValue.toLowerCase().trim();
const searchDialCode = searchValue.trim();

return codes.filter((country) => {
if (country?.dial_code.includes(searchValue) ||
if (country?.dial_code.includes(searchDialCode) ||
country?.name[lang || 'en'].toLowerCase().includes(lowerSearchValue) ||
removeDiacritics(country?.name[lang || 'en'].toLowerCase()).includes(lowerSearchValue)
) {
Expand Down Expand Up @@ -385,12 +386,13 @@ export const CountryList = ({
}, [showOnly, excludedCountries]);

const resultCountries = React.useMemo(() => {
const lowerSearchValue = searchValue.toLowerCase();
const lowerSearchValue = searchValue.toLowerCase().trim();
const searchDialCode = searchValue.trim();

return codes.filter((country) => {
if (country?.dial_code.includes(searchValue) ||
country?.name[lang || 'en'].toLowerCase().includes(lowerSearchValue.trim()) ||
removeDiacritics(country?.name[lang || 'en'].toLowerCase()).includes(lowerSearchValue.trim())
if (country?.dial_code.includes(searchDialCode) ||
country?.name[lang || 'en'].toLowerCase().includes(lowerSearchValue) ||
removeDiacritics(country?.name[lang || 'en'].toLowerCase()).includes(lowerSearchValue)
) {
return country;
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"animated"
],
"author": "George Hope",
"license": "ISC",
"license": "MIT",
"bugs": {
"url": "https://github.com/GeorgeHop/react-native-country-codes-picker/issues"
},
Expand Down