Skip to content

Commit 0209762

Browse files
committed
NPI-4460 clean up comments
1 parent 4442833 commit 0209762

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

tests/test_igslog.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ def test_extract_id_block(self):
2828
# Ensure the extract of ID information works and gives correct dome number:
2929
self.assertEqual(igslog.extract_id_block(v1_data, "/example/path", "ABMF", "v1.0"), ["ABMF", "97103M001"])
3030
self.assertEqual(igslog.extract_id_block(v2_data, "/example/path", "ABMF", "v2.0"), ["ABMF", "97103M001"])
31-
# Check automatic version determination works as expected:
31+
# Check that automatic version determination is used when a version is not provided. This
32+
# leverages determine_log_version() which is already tested above:
3233
self.assertEqual(igslog.extract_id_block(v1_data, "/example/path", "ABMF"), ["ABMF", "97103M001"])
3334

3435
# Check LogVersionError is raised on no data:
@@ -44,6 +45,7 @@ def test_extract_id_block(self):
4445
def test_extract_location_block(self):
4546
# Version 1 Location description results:
4647
v1_location_block = igslog.extract_location_block(v1_data, "/example/path", "v1.0")
48+
# NOTE: this test cannot currently support baselining. This will be addressed in NPI-4492
4749
self.assertEqual(v1_location_block.group(1), b"Les Abymes")
4850
self.assertEqual(v1_location_block.group(2), b"Guadeloupe")
4951

@@ -153,7 +155,6 @@ def test_parse_igs_log_data(self):
153155
# Verify
154156
self.assertTrue(UnitTestBaseliner.verify(objs_to_verify), "Hash verification should pass")
155157
# TODO update verify() to support required datatypes, so it does not crash if hash changes
156-
# TODO check if ndarray has an equivalent to DF.equals()
157158

158159

159160
class TestIgsLogFileParsing(TestCase):

0 commit comments

Comments
 (0)