Skip to content

Commit 0970ba1

Browse files
committed
NPI-3945 addressed PR feedback. Fixed test to cover updated GPSDate properties / accessors
1 parent 1fbe423 commit 0970ba1

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

tests/test_datetime.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,14 @@ def test_gpsdate(self):
7373
self.assertEqual(str(gps_date), "2021-08-31")
7474

7575
gps_date = gps_date.next
76-
self.assertEqual(int(gps_date.yr), 2021)
77-
self.assertEqual(int(gps_date.dy), 244)
78-
self.assertEqual(int(gps_date.gpswk), 2173)
79-
self.assertEqual(int(gps_date.gpswkD[-1]), 3)
76+
self.assertEqual(int(gps_date.yr), 2021) # Deprecated
77+
self.assertEqual(int(gps_date.year), 2021)
78+
self.assertEqual(int(gps_date.dy), 244) # Deprecated
79+
self.assertEqual(int(gps_date.day_of_year), 244)
80+
self.assertEqual(int(gps_date.gpswk), 2173) # Deprecated
81+
self.assertEqual(int(gps_date.gps_week), 2173)
82+
self.assertEqual(int(gps_date.gpswkD[-1]), 3) # Deprecated
83+
self.assertEqual(int(gps_date.gps_week_and_day_of_week[-1]), 3)
8084
self.assertEqual(str(gps_date), "2021-09-01")
8185

8286
yds = np.asarray(["00:000:00000"])
@@ -116,7 +120,7 @@ def test_gpsdate(self):
116120

117121
# And exceptions on trying to construct from incorrect types or date string formats
118122
with self.assertRaises(TypeError):
119-
gn_datetime.GPSDate(5) # An int isn't one of the supported date types
123+
gn_datetime.GPSDate(5) # type: ignore # An int isn't one of the supported date types
120124

121125
with self.assertRaises(ValueError):
122126
gn_datetime.GPSDate("123-12-123") # A string, but not a valid date format

0 commit comments

Comments
 (0)