Documentation wrong word

[williamdes]

Roundcube_TLS_Icon/config.inc.php.dist

Line 9 in 4b1fb86

// Default: 0 (ignores no hops and uses the last Received-Header).

Reading the code:

Roundcube_TLS_Icon/tls_icon.php

Line 34 in 4b1fb86

$Received = $Received_Header[0];

it should be uses the first Received-Header

Do you agree ?

[GermanCoding]

It's probably a matter of perspective.

From a network point of view, the "last header" means "the header from the last hop", which is what is meant here.

From a file-point of view, SMTP appends Received-Headers at the top, so the last header to be inserted is at the top, which is the first one in the file.

[williamdes]

And from what I understand, reading:

Roundcube_TLS_Icon/tls_icon.php

Line 32 in 4b1fb86

$Received = $Received_Header[$ignore_n_hops];

I think we should make clear that the value of tls_icon_ignore_hops is not the number of hops to skip, but the number of the hop to use.
I can not make this plugin work for me, still need to debug :/

[williamdes]

It's probably a matter of perspective.

From a network point of view, the "last header" means "the header from the last hop", which is what is meant here.

From a file-point of view, SMTP appends Received-Headers at the top, so the last header to be inserted is at the top, which is the first one in the file.

Maybe we could make the wording a bit more clear then ?

[GermanCoding]

Yeah, could be more clear