feat: Allow the activity popup window to stay open

This adds a new settings toggle (default disabled). If enabled, the
activity popup window doesn't autoclose if the user clicks anywhere on
screen (the old behaviour). Instead, the user can continue working on
the PC, with the popup remaining available.

If the toggle is disabled, the old behaviour is retained.

Clicking the popup with the right mouse button will close it in all
cases.

Author: GermanCoding

src/SyncTrayzor/NotifyIcon/NotifyIconViewModel.cs

@@ -24,6 +24,7 @@ public class NotifyIconViewModel : PropertyChangedBase, IDisposable
 
         public bool Visible { get; set; }
         public bool MainWindowVisible { get; set; }
+        public bool KeepActivityPopupOpen { get; set; }
         public BindableCollection<FolderViewModel> Folders { get; private set; }
         public FileTransfersTrayViewModel FileTransfersViewModel { get; private set; }
 
@@ -73,7 +74,9 @@ public NotifyIconViewModel(
             this.alertsManager.AlertsStateChanged += AlertsStateChanged;
 
             this.configurationProvider.ConfigurationChanged += ConfigurationChanged;
-            iconAnimationmode = this.configurationProvider.Load().IconAnimationMode;
+            var configuration = this.configurationProvider.Load();
+            iconAnimationmode = configuration.IconAnimationMode;
+            KeepActivityPopupOpen = configuration.KeepActivityPopupOpen;
         }
 
         private void StateChanged(object sender, SyncthingStateChangedEventArgs e)
@@ -117,6 +120,7 @@ private void AlertsStateChanged(object sender, EventArgs e)
         private void ConfigurationChanged(object sender, ConfigurationChangedEventArgs e)
         {
             iconAnimationmode = e.NewConfiguration.IconAnimationMode;
+            KeepActivityPopupOpen = e.NewConfiguration.KeepActivityPopupOpen;
             // Reset, just in case
             SyncthingSyncing = false;
         }

src/SyncTrayzor/NotifyIcon/TaskbarIconResources.xaml

@@ -21,7 +21,7 @@
                     MenuActivation="RightClick"
                     ToolTipText="SyncTrayzor">
         <tb:TaskbarIcon.TrayPopup>
-            <Popup StaysOpen="False" Placement="Relative" HorizontalOffset="-150" VerticalOffset="100" Width="300" PlacementTarget="{Binding ElementName=TaskbarIcon}" AllowsTransparency="True">
+            <Popup StaysOpen="{Binding KeepActivityPopupOpen}" Placement="Relative" HorizontalOffset="-150" VerticalOffset="100" Width="300" PlacementTarget="{Binding ElementName=TaskbarIcon}" AllowsTransparency="True">
                 <i:Interaction.Behaviors>
                     <xaml:PopupConductorBehaviour DataContext="{Binding FileTransfersViewModel}"/>
                 </i:Interaction.Behaviors>

src/SyncTrayzor/Pages/Settings/SettingsView.xaml

@@ -74,6 +74,7 @@
                                 <CheckBox DockPanel.Dock="Top" IsChecked="{Binding ShowDeviceConnectivityBalloons.Value}" Content="{l:Loc SettingsView_ShowDeviceConnectivityBalloons}"/>
                                 <CheckBox DockPanel.Dock="Top" IsChecked="{Binding ShowDeviceOrFolderRejectedBalloons.Value}" Content="{l:Loc SettingsView_ShowDeviceOrFolderRejectedBalloons}"/>
                                 <CheckBox DockPanel.Dock="Top" IsChecked="{Binding ShowTrayIconOnlyOnClose.Value}" Content="{l:Loc SettingsView_OnlyShowTrayIconOnClose}"/>
+                                <CheckBox DockPanel.Dock="Top" IsChecked="{Binding KeepActivityPopupOpen.Value}" Content="{l:Loc SettingsView_KeepActivityPopupOpen}"/>
                                 <StackPanel DockPanel.Dock="Top" Orientation="Horizontal" Margin="0,5,0,0">
                                     <Label Padding="0,0,5,0" Target="{Binding ElementName=IconAnimationModeSelect}" VerticalAlignment="Center" Content="{l:Loc SettingsView_AnimateTrayIcon}"/>
                                     <ComboBox x:Name="IconAnimationModeSelect" ItemsSource="{Binding IconAnimationModes}" SelectedValuePath="Value" SelectedValue="{Binding IconAnimationMode.Value}"/>

src/SyncTrayzor/Pages/Settings/SettingsViewModel.cs

@@ -70,6 +70,7 @@ public class SettingsViewModel : Screen
         public SettingItem<bool> ShowSynchronizedBalloonEvenIfNothingDownloaded { get; }
         public SettingItem<bool> ShowDeviceConnectivityBalloons { get; }
         public SettingItem<bool> ShowDeviceOrFolderRejectedBalloons { get; }
+        public SettingItem<bool> KeepActivityPopupOpen { get; }
 
         public BindableCollection<LabelledValue<IconAnimationMode>> IconAnimationModes { get; }
         public SettingItem<IconAnimationMode> IconAnimationMode { get; }
@@ -141,6 +142,7 @@ public SettingsViewModel(
             ShowSynchronizedBalloonEvenIfNothingDownloaded = CreateBasicSettingItem(x => x.ShowSynchronizedBalloonEvenIfNothingDownloaded);
             ShowDeviceConnectivityBalloons = CreateBasicSettingItem(x => x.ShowDeviceConnectivityBalloons);
             ShowDeviceOrFolderRejectedBalloons = CreateBasicSettingItem(x => x.ShowDeviceOrFolderRejectedBalloons);
+            KeepActivityPopupOpen = CreateBasicSettingItem(x => x.KeepActivityPopupOpen);
 
             IconAnimationModes = new BindableCollection<LabelledValue<IconAnimationMode>>()
             {

src/SyncTrayzor/Properties/Resources.resx

@@ -1002,4 +1002,7 @@ Please donate to my charity fundraising campaign.</value>
   <data name="BarAlertsView_IntelXeGraphics_DismissLink" xml:space="preserve">
     <value>Dismiss</value>
   </data>
+  <data name="SettingsView_KeepActivityPopupOpen" xml:space="preserve">
+    <value>Keep activity popup open (right-click the popup to close)</value>
+  </data>
 </root>

src/SyncTrayzor/Services/Config/Configuration.cs

@@ -28,6 +28,7 @@ public int Version
         public bool ShowDeviceConnectivityBalloons { get; set; }
         public bool ShowDeviceOrFolderRejectedBalloons { get; set; }
         public bool ShowSynchronizedBalloonEvenIfNothingDownloaded { get; set; }
+        public bool KeepActivityPopupOpen { get; set; }
         public string SyncthingAddress { get; set; }
         public bool StartSyncthingAutomatically { get; set; }
 
@@ -110,6 +111,7 @@ public Configuration()
             OpenFolderCommand = "explorer.exe \"{0}\"";
             ShowFileInFolderCommand = "explorer.exe /select, \"{0}\"";
             LogLevel = LogLevel.Info;
+            KeepActivityPopupOpen = false;
         }
 
         public Configuration(Configuration other)
@@ -148,6 +150,7 @@ public Configuration(Configuration other)
             OpenFolderCommand = other.OpenFolderCommand;
             ShowFileInFolderCommand = other.ShowFileInFolderCommand;
             LogLevel = other.LogLevel;
+            KeepActivityPopupOpen = other.KeepActivityPopupOpen;
         }
 
         public override string ToString()
@@ -166,7 +169,8 @@ public override string ToString()
                 $"EnableConflictFileMonitoring={EnableConflictFileMonitoring} " +
                 $"ConflictResolverDeletesToRecycleBin={ConflictResolverDeletesToRecycleBin} PauseDevicesOnMeteredNetworks={PauseDevicesOnMeteredNetworks} " +
                 $"HaveDonated={HaveDonated} IconAnimationMode={IconAnimationMode} OpenFolderCommand={OpenFolderCommand} ShowFileInFolderCommand={ShowFileInFolderCommand}" +
-                $"LogLevel={LogLevel}>";
+                $"LogLevel={LogLevel}" +
+                $"KeepActivityPopupOpen={KeepActivityPopupOpen}>";
         }
     }
 }

src/SyncTrayzor/Xaml/PopupConductorBehaviour.cs

@@ -2,6 +2,7 @@
 using System;
 using System.Windows;
 using System.Windows.Controls.Primitives;
+using System.Windows.Input;
 
 namespace SyncTrayzor.Xaml
 {
@@ -20,12 +21,14 @@ protected override void AttachHandlers()
         {
             AssociatedObject.Opened += Opened;
             AssociatedObject.Closed += Closed;
+            AssociatedObject.PreviewMouseUp += ManualClose;
         }
 
         protected override void DetachHandlers()
         {
             AssociatedObject.Opened -= Opened;
             AssociatedObject.Closed -= Closed;
+            AssociatedObject.PreviewMouseUp -= ManualClose;
         }
 
         private void Opened(object sender, EventArgs e)
@@ -39,5 +42,13 @@ private void Closed(object sender, EventArgs e)
             if (DataContext is IScreenState screenState)
                 screenState.Close();
         }
+
+        private void ManualClose(object sender, MouseButtonEventArgs e)
+        {
+            if (e.ChangedButton == MouseButton.Right)
+            {
+                AssociatedObject.IsOpen = false;
+            }
+        }
     }
 }