feat(installer)!: Stop all SyncTrayzor processes upon install/upgrade#242
Open
GermanCoding wants to merge 1 commit into
Open
feat(installer)!: Stop all SyncTrayzor processes upon install/upgrade#242GermanCoding wants to merge 1 commit into
GermanCoding wants to merge 1 commit into
Conversation
This is a potentially breaking change, and slightly invasive. Old SyncTrayzor versions (< 1.1.29) did not stop themselves upon uninstall, causing "ghost" SyncTrayzor processes to remain on the system. These can cause various issues, but most noticeably is that they lock the CEF cache, causing startup failures for the new instance. We cannot trivially stop these, as uninstaller information may already be lost if the user manually uninstalled v1 but did not stop the ghost afterwards. This change therefore ensures that *all* instances are stopped (if we have permission), no matter where they come from. This may cause disruptions for unrelated portable versions or cross-user instances, but the user can simply re-start these as needed. Having multiple SyncTrayzors running on the system is likely an edge-case anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potentially breaking change, and slightly invasive. Old SyncTrayzor versions (< 1.1.29) did not stop themselves upon uninstall, causing "ghost" SyncTrayzor processes to remain on the system. These can cause various issues, but most noticeably is that they lock the CEF cache, causing startup failures for the new instance.
We cannot trivially stop these, as uninstaller information may already be lost if the user manually uninstalled v1 but did not stop the ghost afterwards. This change therefore ensures that all instances are stopped (if we have permission), no matter where they come from. This may cause disruptions for unrelated portable versions or cross-user instances, but the user can simply re-start these as needed. Having multiple SyncTrayzors running on the system is likely an edge-case anyway.