Skip to content

feat(installer)!: Stop all SyncTrayzor processes upon install/upgrade #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GermanCoding wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(installer)!: Stop all SyncTrayzor processes upon install/upgrade #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions installer/common.iss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,26 @@ begin
end;
end;

function StopRunningSyncTrayzorProcesses(): Boolean;
var
ResultCode: Integer;
begin
Result := True;

if not Exec(ExpandConstant('{sys}\taskkill.exe'), '/IM SyncTrayzor.exe /F /T', '', SW_HIDE, ewWaitUntilTerminated, ResultCode) then
begin
Log('Failed to launch taskkill for SyncTrayzor.exe processes; continuing setup');
end
else if ResultCode = 0 then
begin
Log('Requested termination of SyncTrayzor.exe processes');
end
else
begin
Log('taskkill exited with code ' + IntToStr(ResultCode) + '; continuing setup');
end;
end;

procedure RestoreAutostartRegistry();
var
NewValue: string;
Expand Down Expand Up @@ -399,6 +419,8 @@ end;
function InitializeSetup(): Boolean;
begin
Result := True;
StopRunningSyncTrayzorProcesses();

if not EnsureNoLegacyX86() then
begin
Result := False;
Expand Down
Loading