Add option to get resource perspective without creating directory.#4659
Open
beeyayjay wants to merge 4 commits into
Open
Add option to get resource perspective without creating directory.#4659beeyayjay wants to merge 4 commits into
beeyayjay wants to merge 4 commits into
Conversation
Member
|
@beeyayjay this looks good, could you include an update to the label and info for the "Delete local copy" configuration screen in this PR? |
Member
|
@beeyayjay I pushed a commit with my suggested verbage, please review it and confirm it makes sense. |
janette
approved these changes
Feb 17, 2026
Member
|
Hold to merge into 4.x release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [issue#]
27408
When the DKAN Resource setting, "Delete local resource", is enabled, the local resouce directories are deleted after a harvest run, but are recreated after harvest revert. This leaves unused and useless directories in the filesystem.
Describe your changes
Added an optional parameter to ResourceLocalizer::get(), so that calling functions can skip the code that recreates the directory
QA Steps
ls -l web/sites/default/files/resources) and note the total number of items.ddev drush dkan:harvest:run sample_content, then run cron a couple of timesls -l web/sites/default/files/resourcesand confirm the total hasn't changedddev drush dkan:harvest:revert sample_content, the nrun cronls -l web/sites/default/files/resourcesand confirm the total still hasn't changedChecklist before requesting review
If any of these are left unchecked, please provide an explanation
Bug fix