Handle exceptions within harvest revert.#4697
Draft
paul-m wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR against 2.x so I can use it to generate a patch for my application.
Repro:
drush dkan:harvest:revert YOUR_HARVESTdrush dkan:harvest:run YOUR_HARVESTThere is no way around this, if you want to use harvests to manage the datasets after you've deleted one. The harvest system thinks you still have all the datasets, even though one is missing.
The solution is to handle the dataset not found exception, and let the harvest revert continue to run. This way all the hashes will be removed, which signals to the harvest system that the datasets have not been created.
Fixes [issue#]
Describe your changes
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation