Skip to content

Frontend module cleanup#4699

Merged
dafeder merged 14 commits into
4.xfrom
frontend-more-cleanup
May 26, 2026
Merged

Frontend module cleanup#4699
dafeder merged 14 commits into
4.xfrom
frontend-more-cleanup

Conversation

@paul-m
Copy link
Copy Markdown
Contributor

@paul-m paul-m commented Apr 27, 2026

Mainly updates to dkan_js_frontend.

  • Turns route names like 'about' into dkan_js_frontend.about, etc. Try drush route | grep dkan
  • Refactors the controller render method into less code, using values Drupal has already computed.
  • Accepts the typehinted route matcher in the controller method so we can more easily target dataset routes for ID check.
  • Adds cache invalidation information for the rendered page.
  • Adds 'view content' permission to all our routes.

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform. Be as specific as possible, provide examples if appropriate.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@paul-m paul-m changed the base branch from 2.x to 4.x April 27, 2026 15:52
@paul-m paul-m marked this pull request as ready for review May 22, 2026 17:23
@dafeder dafeder changed the title Frontend more cleanup Frontend module cleanup May 26, 2026
@dafeder dafeder merged commit f65ec25 into 4.x May 26, 2026
17 checks passed
@dafeder dafeder deleted the frontend-more-cleanup branch May 26, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants