Send back 503 on query requests if the database is otherwise occupied.#4704
Draft
paul-m wants to merge 6 commits into
Draft
Send back 503 on query requests if the database is otherwise occupied.#4704paul-m wants to merge 6 commits into
paul-m wants to merge 6 commits into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [issue#]
Describe your changes
On a client project, we got some interesting watchdog logs, sorting them by frequency. The log represented a week of data.
The top entry is this one:
This had 4,285 occurrences within a week, which is 612 a day.
This means we can handle this error better, and turn it into a useful 429 response.
This PR handles this within the
AbstractQueryController, which is where it is most likely to occur (at least on our site).We could place similar catch blocks on other controllers as well, or figure out a more centralized way to handle this.
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation