chore: pin getstream to stream-py auto-reconnect branch#7
Merged
Conversation
Repoint the `getstream` git source from `fix/drop-late-subscriber-offer` (now merged into stream-py `main`) to `fix/auto-reconnect-signaling-ws`, which is rebased on the same `main` and therefore picks up both fixes. Resolves to stream-py commit a81381fd.
|
@aliev must be a member of the GetStreamio team on Vercel to deploy. Learn more about collaboration on Vercel and other options here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Under concurrent load, transient WebSocket drops between the agent and SFU (TCP reset, missed health check, abrupt close) leave the session hanging until the frontend's own timeout fires.
WebSocketClientin stream-py has no reconnect of its own — it logs the failure and stops, and the surrounding session never recovers.stream-py PR #241 wires the signaling WS into the existing
ReconnectionManagerso a brief drop now triggers aFASTreconnect (escalating toREJOINon failure) instead of silently killing the session. This change picks up that fix so we can validate it in the cluster.The previously pinned
fix/drop-late-subscriber-offeris already merged into stream-pymain; the auto-reconnect branch is rebased on that samemain, so this pin includes both fixes.Changes
getstreamsource fromfix/drop-late-subscriber-offer→fix/auto-reconnect-signaling-ws.getstreamat commita81381fd.Drop the
getstreamdeclaration and source entry once the fix is in a releasedgetstreamversion.