Clean up TalkBack accessibility semantics (#6498)

* compose: Move voice recording row labels onto child leaves

The locked and overview rows set contentDescription on a mergeDescendants
container, which concatenates with the child descriptions (duration,
progress) so any new child silently shifts the announce. Move the label
onto a child leaf (the leading icon and the waveform) so the announce is
composed from the children in visual order, and keep the merge only as the
single TalkBack focus stop.

* compose: Tidy empty merge-semantics blocks

Remove the empty Modifier.semantics(mergeDescendants = true) {} blocks on
Rows that already have a clickable or toggleable, where the merge boundary
is implicit. Keep the load-bearing ones (containers with no click handler)
and add a short comment explaining that they group their children into a
single TalkBack focus stop.

* compose: Lead the Giphy preview announcement with the preview label

The focused ephemeral Giphy preview announced "Only visible to you, [alt
text], Giphy". Compose a single description that leads with "Giphy
preview", then the alt text, then "Only visible to you", and apply it via
clearAndSetSemantics so the merged stop reads in that order. Add the
stream_compose_giphy_preview_label string in all supported locales.

* compose: Group the media attachment grid as a TalkBack traversal group

Add isTraversalGroup to the multi-image grid container so that once focus
is inside the grid, a swipe walks every tile in order before leaving,
instead of letting the surrounding list pull focus across rows mid-grid.

* compose: Document Giphy preview a11y ownership on MessageGiphyContent

MessageGiphyContent composes and owns the focused preview's merged
TalkBack description and clears the inner GiphyAttachmentContent
semantics. Note in the KDoc that customizing the preview's accessibility
announcement should override MessageGiphyContent rather than
GiphyAttachmentContent.

Author: andremion

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/attachments/content/MediaAttachmentContent.kt

@@ -59,6 +59,7 @@ import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.semantics.contentDescription
+import androidx.compose.ui.semantics.isTraversalGroup
 import androidx.compose.ui.semantics.semantics
 import androidx.compose.ui.semantics.testTag
 import androidx.compose.ui.text.style.TextAlign
@@ -168,7 +169,11 @@ public fun MediaAttachmentContent(
                 stringResource(UiCommonR.string.stream_ui_message_list_semantics_message_attachments, attachments.size)
             Row(
                 modifier = Modifier
-                    .semantics { this.contentDescription = description }
+                    .semantics {
+                        this.contentDescription = description
+                        // Group the grid so a TalkBack swipe walks every tile before leaving it.
+                        isTraversalGroup = true
+                    }
                     .padding(MessageStyling.messageSectionPadding),
                 horizontalArrangement = Arrangement.spacedBy(gridSpacing),
             ) {

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/messages/GiphyMessageContent.kt

@@ -48,6 +48,7 @@ import androidx.compose.ui.platform.LocalView
 import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
+import androidx.compose.ui.semantics.contentDescription
 import androidx.compose.ui.semantics.semantics
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
@@ -96,6 +97,8 @@ public fun GiphyMessageContent(
     val cancelledAnnouncement = stringResource(R.string.stream_compose_message_list_giphy_cancelled)
     val shuffledAnnouncement = stringResource(R.string.stream_compose_message_list_giphy_shuffled)
 
+    val giphyPreviewLabel = stringResource(R.string.stream_compose_giphy_preview_label)
+
     val isTouchExplorationEnabled = rememberIsTouchExplorationEnabled()
     val previewFocusRequester = remember { FocusRequester() }
     // Track whether the preview has already requested focus so that a LazyColumn dispose +
@@ -120,7 +123,8 @@ public fun GiphyMessageContent(
                 .applyIf(isTouchExplorationEnabled) {
                     focusRequester(previewFocusRequester).focusable()
                 }
-                .semantics(mergeDescendants = true) {},
+                // Lead the preview's merged TalkBack announcement with the "Giphy preview" label.
+                .semantics(mergeDescendants = true) { contentDescription = giphyPreviewLabel },
         ) {
             Row(
                 modifier = Modifier

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/messages/QuotedMessage.kt

@@ -129,6 +129,7 @@ internal fun MessageComposerQuotedMessage(
             message = message,
             currentUser = currentUser,
             replyMessage = null,
+            // No click handler on the composer quoted preview; merge into one TalkBack stop.
             modifier = Modifier.semantics(mergeDescendants = true) {},
         )
 

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/poll/PollAnswers.kt

@@ -178,6 +178,7 @@ internal fun PollAnswersItem(
         verticalArrangement = Arrangement.spacedBy(StreamTokens.spacingXs),
     ) {
         Column(
+            // No click handler; merge into one TalkBack stop.
             modifier = Modifier.semantics(mergeDescendants = true) {},
             verticalArrangement = Arrangement.spacedBy(StreamTokens.spacingXs),
         ) {

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/poll/PollOptionVotesDialog.kt

@@ -164,6 +164,7 @@ private fun Content(
                     Row(
                         modifier = Modifier
                             .fillMaxWidth()
+                            // No click handler; merge into one TalkBack stop.
                             .semantics(mergeDescendants = true) {},
                         horizontalArrangement = Arrangement.End,
                     ) {

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/poll/PollVoteItem.kt

@@ -44,6 +44,7 @@ internal fun PollVoteItem(
     val borderSize = 2.dp
 
     Row(
+        // No click handler; merge into one TalkBack stop.
         modifier = modifier.semantics(mergeDescendants = true) {},
         verticalAlignment = Alignment.CenterVertically,
         horizontalArrangement = Arrangement.spacedBy(StreamTokens.spacingSm),

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/attachments/poll/PollSwitchList.kt

@@ -179,8 +179,7 @@ private fun PollSwitchHeader(
                 value = enabled,
                 role = Role.Switch,
                 onValueChange = onCheckedChange,
-            )
-            .semantics(mergeDescendants = true) {},
+            ),
         verticalAlignment = Alignment.CenterVertically,
     ) {
         Column(
@@ -230,8 +229,7 @@ private fun LimitVotesPerPerson(
                     value = enabled,
                     role = Role.Switch,
                     onValueChange = onCheckedChange,
-                )
-                .semantics(mergeDescendants = true) {},
+                ),
             verticalAlignment = Alignment.CenterVertically,
         ) {
             Column(

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/composer/internal/AudioRecordingContent.kt

@@ -196,13 +196,14 @@ internal fun MessageComposerAudioRecordingLockedContent(
             modifier = RecordingBarModifier
                 .focusRequester(rowFocusRequester)
                 .focusable()
-                .semantics(mergeDescendants = true) { contentDescription = rowLabel },
+                // Merge the row into one TalkBack stop; the leading icon owns the row label.
+                .semantics(mergeDescendants = true) {},
             verticalAlignment = Alignment.CenterVertically,
         ) {
             Box(modifier = Modifier.size(48.dp), contentAlignment = Alignment.Center) {
                 Icon(
                     painter = painterResource(id = R.drawable.stream_design_ic_voice),
-                    contentDescription = null,
+                    contentDescription = rowLabel,
                     tint = ChatTheme.colors.accentError,
                 )
             }
@@ -314,7 +315,8 @@ private fun RowScope.OverviewPlaybackRow(
             .fillMaxHeight()
             .focusRequester(focusRequester)
             .focusable()
-            .semantics(mergeDescendants = true) { contentDescription = rowLabel },
+            // Merge the row into one TalkBack stop; the waveform owns the row label.
+            .semantics(mergeDescendants = true) {},
         verticalAlignment = Alignment.CenterVertically,
     ) {
         val playbackInMs = (currentProgress * state.durationInMs).toInt()
@@ -330,6 +332,7 @@ private fun RowScope.OverviewPlaybackRow(
         StaticWaveformSlider(
             modifier = Modifier
                 .fillMaxSize()
+                .semantics { contentDescription = rowLabel }
                 .padding(start = StreamTokens.spacingMd, top = 8.dp, bottom = 8.dp),
             waveformData = state.waveform,
             progress = currentProgress,

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/composer/internal/MessageComposerEditIndicator.kt

@@ -85,6 +85,7 @@ private fun EditIndicatorCard(body: QuotedMessageBody) {
             )
             .padding(StreamTokens.spacingXs)
             .height(IntrinsicSize.Min)
+            // No click handler; merge into one TalkBack stop.
             .semantics(mergeDescendants = true) {},
         horizontalArrangement = Arrangement.spacedBy(StreamTokens.spacingXs),
     ) {

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/header/ChannelHeader.kt

@@ -200,7 +200,6 @@ internal fun DefaultChannelHeaderCenterContent(
                     onClickLabel = onHeaderTitleClickLabel,
                     role = Role.Button,
                 ) { callback(channel) }
-                    .semantics(mergeDescendants = true) {}
             },
         horizontalAlignment = Alignment.CenterHorizontally,
         verticalArrangement = Arrangement.Center,