Fix pill preview height and re-target the click testTag

Two related fixes on the pill composable:

- Bound the inner Row to Modifier.height(IntrinsicSize.Min). VerticalDivider
  uses fillMaxHeight() internally, which was unbounded inside the Surface
  preview and stretched the pill across the rendered surface. With
  IntrinsicSize.Min, the divider's height resolves to the tallest
  non-flexible child (the label row or the close icon).

- Move the Stream_ScrollToFirstUnreadButton testTag from the Surface to the
  inner clickable Row. The Surface is not interactive, so a UI test that
  finds the node by tag and performs a click would land on a non-clickable
  node. With the tag on the click target, finding by tag and clicking now
  invokes the scroll handler, mirroring the dismiss tag on the X icon.

Author: andremion

stream-chat-android-compose/api/stream-chat-android-compose.api

@@ -1519,7 +1519,7 @@ public final class io/getstream/chat/android/compose/ui/components/messages/Comp
 public final class io/getstream/chat/android/compose/ui/components/messages/ComposableSingletons$ScrollToFirstUnreadButtonKt {
 	public static final field INSTANCE Lio/getstream/chat/android/compose/ui/components/messages/ComposableSingletons$ScrollToFirstUnreadButtonKt;
 	public fun <init> ()V
-	public final fun getLambda$-1749808746$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
+	public final fun getLambda$-1405339857$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
 }
 
 public final class io/getstream/chat/android/compose/ui/components/messages/ComposableSingletons$SwipeToReplyIconKt {

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/messages/ScrollToFirstUnreadButton.kt

@@ -18,7 +18,11 @@ package io.getstream.chat.android.compose.ui.components.messages
 
 import androidx.compose.foundation.BorderStroke
 import androidx.compose.foundation.layout.Arrangement
+import androidx.compose.foundation.layout.IntrinsicSize
 import androidx.compose.foundation.layout.Row
+import androidx.compose.foundation.layout.fillMaxHeight
+import androidx.compose.foundation.layout.height
+import androidx.compose.foundation.layout.heightIn
 import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.shape.CircleShape
@@ -65,20 +69,23 @@ internal fun ScrollToFirstUnreadButton(
 ) {
     Surface(
         modifier = modifier
-            .shadow(StreamTokens.spacing2xs, shape = CircleShape)
-            .testTag("Stream_ScrollToFirstUnreadButton"),
+            .shadow(StreamTokens.spacing2xs, shape = CircleShape),
         shape = CircleShape,
         color = ChatTheme.colors.backgroundCoreElevation1,
         contentColor = ChatTheme.colors.textPrimary,
-        border = BorderStroke(StreamTokens.borderStrokeSubtle, ChatTheme.colors.borderCoreSubtle),
+        border = BorderStroke(1.dp, ChatTheme.colors.borderCoreSubtle),
     ) {
         Row(
+            modifier = Modifier
+                .height(IntrinsicSize.Min)
+                .heightIn(min = 40.dp),
             verticalAlignment = Alignment.CenterVertically,
         ) {
             Row(
                 modifier = Modifier
+                    .testTag("Stream_ScrollToFirstUnreadButton")
                     .clickable(role = Role.Button, onClick = onClick)
-                    .padding(vertical = StreamTokens.spacingXs)
+                    .fillMaxHeight()
                     .padding(start = StreamTokens.spacingSm, end = StreamTokens.spacingXs),
                 horizontalArrangement = Arrangement.spacedBy(StreamTokens.spacing2xs),
                 verticalAlignment = Alignment.CenterVertically,
@@ -98,14 +105,15 @@ internal fun ScrollToFirstUnreadButton(
                 )
             }
             VerticalDivider(
+                modifier = Modifier.padding(vertical = StreamTokens.spacing2xs),
                 thickness = StreamTokens.borderStrokeSubtle,
                 color = ChatTheme.colors.borderCoreSubtle,
             )
             Icon(
                 modifier = Modifier
-                    .clickable(role = Role.Button, onClick = onDismiss)
                     .testTag("Stream_ScrollToFirstUnreadButton_Dismiss")
-                    .padding(vertical = StreamTokens.spacingXs)
+                    .clickable(role = Role.Button, onClick = onDismiss)
+                    .fillMaxHeight()
                     .padding(start = StreamTokens.spacingXs, end = StreamTokens.spacingSm)
                     .size(IconSize),
                 painter = painterResource(R.drawable.stream_design_ic_xmark),
@@ -117,10 +125,15 @@ internal fun ScrollToFirstUnreadButton(
 
 @Composable
 @Preview(showBackground = true)
-private fun Preview() {
+private fun ScrollToFirstUnreadButtonPreview() {
     ChatTheme {
-        ScrollToFirstUnreadButton(
-            unreadCount = 9,
-        )
+        ScrollToFirstUnreadButton()
     }
 }
+
+@Composable
+internal fun ScrollToFirstUnreadButton() {
+    ScrollToFirstUnreadButton(
+        unreadCount = 9,
+    )
+}

stream-chat-android-compose/src/test/kotlin/io/getstream/chat/android/compose/ui/components/messages/ScrollToFirstUnreadButtonTest.kt

@@ -32,23 +32,9 @@ internal class ScrollToFirstUnreadButtonTest : PaparazziComposeTest {
     )
 
     @Test
-    fun `pill with single unread`() {
-        snapshotWithDarkMode {
-            ScrollToFirstUnreadButton(unreadCount = 1)
-        }
-    }
-
-    @Test
-    fun `pill with default unread count`() {
-        snapshotWithDarkMode {
-            ScrollToFirstUnreadButton(unreadCount = 9)
-        }
-    }
-
-    @Test
-    fun `pill with large unread count`() {
-        snapshotWithDarkMode {
-            ScrollToFirstUnreadButton(unreadCount = 999)
+    fun `pill with unread count`() {
+        snapshotWithDarkModeRow {
+            ScrollToFirstUnreadButton()
         }
     }
 }