Remove redundant hardcoded sizes on Compose design icons (#6478)

* refactor(compose): drop redundant 20dp hardcoded sizes on design icons

Removes Modifier.size(20.dp) from Icon call sites that paint a 20dp
intrinsic stream_design_ic_* drawable. The size is redundant because
Icon falls back to the painter's intrinsic size when no size modifier
is applied, and removing it lets integrators override the drawable
file to drive the rendered size.

Touched: ComposerCancelIcon, AudioRecordAttachmentContent
PlaybackToggleButton, UnsupportedAttachmentContent, VideoPlaybackControls
play/pause toggle, AddMembersScreen back arrow.

* refactor(compose): drop redundant 20dp sizes on poll icons

Removes Modifier.size(20.dp) from poll-feature icons painted with 20dp
intrinsic drawables: PollAnswers add-answer button, PollOptionList
remove and error icons, PollSwitchList StepperButton minus/plus icons.

* refactor(compose): drop redundant 20dp sizes in media gallery preview

Removes Modifier.size(20.dp) from the share/cancel-share and photos
icons in MediaGalleryPreviewScreen, and from the option-row icon in
MediaGalleryPreviewOptionsMenu. Every painter consumed by these call
sites is a 20dp intrinsic stream_design_ic_* drawable, so the size
modifier was redundant.

* refactor(compose): drop redundant 20dp sizes in ContextualMenuItem

Removes Modifier.size(20.dp) from both leadingIcon and trailingIcon
Icons in ContextualMenuItem. Every caller (message action options,
the in-file MenuItem preview) passes a 20dp intrinsic
stream_design_ic_* drawable, so the hardcoded size was redundant and
blocked integrator drawable overrides from propagating.

* refactor(compose): drop redundant 20dp size on MessageFailedIcon

The MessageFailedIcon factory paints a 20dp intrinsic
stream_design_ic_exclamation_circle_fill, so the .size(20.dp) injected
into MessageFailedIconParams.modifier by callers was redundant.
Removes it from the two MessageContainer call sites and the
PollMessageContent call site.

Author: andremion

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/attachments/content/AudioRecordAttachmentContent.kt

@@ -300,7 +300,6 @@ internal fun PlaybackToggleButton(
     ) {
         Icon(
             painter = icon,
-            modifier = Modifier.size(20.dp),
             contentDescription = label,
         )
     }

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/attachments/content/UnsupportedAttachmentContent.kt

@@ -21,7 +21,6 @@ import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.Row
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.padding
-import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.shape.RoundedCornerShape
 import androidx.compose.material3.Icon
 import androidx.compose.material3.Text
@@ -32,7 +31,6 @@ import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.style.TextOverflow
 import androidx.compose.ui.tooling.preview.Preview
-import androidx.compose.ui.unit.dp
 import io.getstream.chat.android.compose.R
 import io.getstream.chat.android.compose.state.messages.attachments.AttachmentState
 import io.getstream.chat.android.compose.ui.theme.ChatTheme
@@ -80,7 +78,6 @@ public fun UnsupportedAttachmentContent(
                         painter = painterResource(R.drawable.stream_design_ic_unsupported_attachment),
                         tint = ChatTheme.colors.textPrimary,
                         contentDescription = null,
-                        modifier = Modifier.size(20.dp),
                     )
 
                     Text(

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/attachments/preview/MediaGalleryPreviewOptionsMenu.kt

@@ -22,7 +22,6 @@ import androidx.compose.foundation.layout.Row
 import androidx.compose.foundation.layout.Spacer
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.padding
-import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.layout.width
 import androidx.compose.material3.ExperimentalMaterial3Api
 import androidx.compose.material3.Icon
@@ -37,7 +36,6 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.style.TextOverflow
-import androidx.compose.ui.unit.dp
 import io.getstream.chat.android.compose.R
 import io.getstream.chat.android.compose.state.mediagallerypreview.Delete
 import io.getstream.chat.android.compose.state.mediagallerypreview.MediaGalleryPreviewOption
@@ -132,7 +130,6 @@ internal fun MediaGalleryOptionItem(
         verticalAlignment = Alignment.CenterVertically,
     ) {
         Icon(
-            modifier = Modifier.size(20.dp),
             painter = option.iconPainter,
             tint = option.iconColor,
             contentDescription = option.title,

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/attachments/preview/MediaGalleryPreviewScreen.kt

@@ -873,7 +873,6 @@ internal fun MediaGalleryPreviewShareIcon(
         Icon(
             painter = painterResource(id = painter),
             contentDescription = stringResource(id = description),
-            modifier = Modifier.size(20.dp),
         )
     }
 }
@@ -949,7 +948,6 @@ internal fun MediaGalleryPreviewPhotosIcon(
         Icon(
             painter = painterResource(id = R.drawable.stream_design_ic_gallery),
             contentDescription = stringResource(id = R.string.stream_compose_image_preview_photos),
-            modifier = Modifier.size(20.dp),
         )
     }
 }

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/attachments/preview/internal/VideoPlaybackControls.kt

@@ -114,7 +114,6 @@ internal fun VideoPlaybackControls(
             Icon(
                 painter = painterResource(icon),
                 contentDescription = stringResource(contentDescription),
-                modifier = Modifier.size(20.dp),
             )
         }
 

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/channel/info/AddMembersScreen.kt

@@ -179,7 +179,6 @@ private fun AddMembersHeader(
             style = StreamButtonStyleDefaults.secondaryGhost,
         ) {
             Icon(
-                modifier = Modifier.size(20.dp),
                 painter = painterResource(id = R.drawable.stream_design_ic_arrow_left),
                 contentDescription = stringResource(id = UiCommonR.string.stream_ui_back_button),
             )

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/ComposerCancelIcon.kt

@@ -19,7 +19,6 @@ package io.getstream.chat.android.compose.ui.components
 import androidx.compose.foundation.background
 import androidx.compose.foundation.border
 import androidx.compose.foundation.layout.padding
-import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.shape.CircleShape
 import androidx.compose.material3.Icon
 import androidx.compose.runtime.Composable
@@ -52,7 +51,6 @@ public fun ComposerCancelIcon(
             .border(2.dp, colors.controlRemoveBorder, CircleShape)
             .padding(2.dp)
             .background(color = colors.controlRemoveBg, shape = CircleShape)
-            .size(20.dp)
             .clickable(bounded = false, onClick = onClick),
         painter = painterResource(R.drawable.stream_design_ic_xmark_small),
         contentDescription = contentDescription,

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/common/ContextualMenu.kt

@@ -25,7 +25,6 @@ import androidx.compose.foundation.layout.Row
 import androidx.compose.foundation.layout.defaultMinSize
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.padding
-import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.layout.width
 import androidx.compose.foundation.shape.RoundedCornerShape
 import androidx.compose.material3.HorizontalDivider
@@ -96,7 +95,6 @@ internal fun ContextualMenuItem(
                 painter = it,
                 contentDescription = null,
                 tint = iconColor,
-                modifier = Modifier.size(20.dp),
             )
         }
 
@@ -114,7 +112,6 @@ internal fun ContextualMenuItem(
                 painter = it,
                 contentDescription = null,
                 tint = iconColor,
-                modifier = Modifier.size(20.dp),
             )
         }
     }

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/messages/PollMessageContent.kt

@@ -160,7 +160,6 @@ public fun PollMessageContent(
                 params = MessageFailedIconParams(
                     modifier = Modifier
                         .padding(vertical = StreamTokens.spacingXs)
-                        .size(20.dp)
                         .align(Alignment.TopEnd),
                     message = message,
                 ),

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/poll/PollAnswers.kt

@@ -58,7 +58,6 @@ import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.semantics.semantics
 import androidx.compose.ui.tooling.preview.Preview
-import androidx.compose.ui.unit.dp
 import androidx.compose.ui.window.Popup
 import io.getstream.chat.android.compose.R
 import io.getstream.chat.android.compose.ui.components.avatar.AvatarSize
@@ -156,7 +155,6 @@ private fun Content(
                         Icon(
                             painter = painterResource(id = R.drawable.stream_design_ic_edit),
                             contentDescription = stringResource(id = R.string.stream_compose_add_answer),
-                            modifier = Modifier.size(20.dp),
                         )
                     }
                 }