Skip to content

Commit 71afdb5

Browse files
fix(ai): address PR review comments
- Fix duplicated detection regex (MessageContentFactory → ChatComponentFactory) - Use portable perl -i -pe for bulk drawable rename (works on macOS + Linux) - Fix MentionSuggestionItem/List JSON mappings (null → actual v7 names) - Complete drawableRenames JSON with all mappings from §5.8
1 parent 13e3c1a commit 71afdb5

1 file changed

Lines changed: 11 additions & 6 deletions

File tree

ai-docs/ai-migration.md

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ rg "StreamColors|StreamTypography|StreamDimens|StreamShapes|StreamRippleConfigur
5656
rg "reactionIconFactory|messageContentFactory|autoTranslationEnabled|isComposerLinkPreviewEnabled|attachmentsPickerTabFactories|attachmentPickerTheme|dimens\s*=|shapes\s*=" --type kotlin
5757

5858
# §3.4 — ChatComponentFactory / MessageContentFactory
59-
rg "MessageContentFactory|MessageContentFactory\b" --type kotlin
59+
rg "ChatComponentFactory|MessageContentFactory\b" --type kotlin
6060

6161
# §4 — Package relocations
6262
rg "io\.getstream\.chat\.android\.state\.|io\.getstream\.chat\.android\.offline\.|io\.getstream\.chat\.android\.uiutils\." --type kotlin
@@ -606,8 +606,8 @@ All `stream_compose_ic_*` drawables are renamed to `stream_design_ic_*` in v7. A
606606
# Find all references
607607
rg "stream_compose_ic_" --type kotlin --type xml
608608

609-
# Bulk rename (sed example)
610-
find . -name "*.kt" -o -name "*.xml" | xargs sed -i '' 's/stream_compose_ic_/stream_design_ic_/g'
609+
# Bulk rename (portable — works on macOS and Linux)
610+
find . \( -name "*.kt" -o -name "*.xml" \) -print0 | xargs -0 perl -i -pe 's/stream_compose_ic_/stream_design_ic_/g'
611611
```
612612

613613
**Key renames (not 1:1 — name also changed):**
@@ -943,8 +943,8 @@ The typing indicator is now rendered as an inline item in the message list, not
943943
"ImageAvatar": null,
944944
"InitialsAvatar": null,
945945
"UserAvatarRow": null,
946-
"MentionSuggestionItem": null,
947-
"MentionSuggestionList": null,
946+
"MentionSuggestionItem": "UserSuggestionItem",
947+
"MentionSuggestionList": "UserSuggestionList",
948948
"CancelIcon": "ComposerCancelIcon",
949949
"DefaultQueryFilter": "DefaultUserQueryFilter",
950950
"PollConfig": "CreatePollParams",
@@ -1032,7 +1032,12 @@ The typing indicator is now rendered as an inline item in the message list, not
10321032
"stream_compose_ic_clear": "stream_design_ic_xmark",
10331033
"stream_compose_ic_error": "stream_design_ic_exclamation_circle",
10341034
"stream_compose_ic_check_circle": "stream_design_ic_checkmark",
1035-
"stream_compose_ic_mute": "stream_design_ic_bell_slash"
1035+
"stream_compose_ic_mute": "stream_design_ic_bell_slash",
1036+
"stream_compose_ic_mentions": "stream_design_ic_mention",
1037+
"stream_compose_ic_mention": "stream_design_ic_at",
1038+
"stream_compose_ic_cancel": "stream_design_ic_xmark",
1039+
"stream_compose_ic_new_chat": null,
1040+
"stream_compose_ic_person": null
10361041
},
10371042
"removedEvents": {
10381043
"ChannelInfoViewEvent.HideChannelError": null,

0 commit comments

Comments
 (0)