Fix delete message not working when offline (SYNC_NEEDED) (#6184)

* Fix delete message not working when offline (SYNC_NEEDED)

Co-Authored-By: Claude <noreply@anthropic.com>

* Update DeleteMessageListener tests for SYNC_NEEDED remote delete

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: VelikovPetar

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/utils/message/MessageUtils.kt

@@ -230,10 +230,9 @@ public fun Message.shouldDeleteRemote(currentUserId: String?): Result<Unit> {
         return Result.Failure(error)
     }
     // 2. type = 'error'/'ephemeral' - not persisted on server, delete only locally
-    // 3. syncStatus = 'IN_PROGRESS'/`SYNC_NEEDED`/`FAILED_PERMANENTLY` - not persisted on server, delete only locally
+    // 3. syncStatus = 'IN_PROGRESS'/`FAILED_PERMANENTLY` - not persisted on server, delete only locally
     if (isError() || isEphemeral() ||
         syncStatus == SyncStatus.IN_PROGRESS ||
-        syncStatus == SyncStatus.SYNC_NEEDED ||
         syncStatus == SyncStatus.FAILED_PERMANENTLY
     ) {
         val error = Error.GenericError("Message is local-only, don't call DeleteMessage API")

stream-chat-android-client/src/test/java/io/getstream/chat/android/client/utils/message/MessageUtilsTest.kt

@@ -629,40 +629,40 @@ internal class MessageUtilsTest {
     }
 
     @Test
-    fun `shouldDeleteRemote should return Failure for SYNC_NEEDED sync status`() {
+    fun `shouldDeleteRemote should return Failure for FAILED_PERMANENTLY sync status`() {
         val message = randomMessage(
             type = MessageType.REGULAR,
-            syncStatus = SyncStatus.SYNC_NEEDED,
+            syncStatus = SyncStatus.FAILED_PERMANENTLY,
         )
         val result = message.shouldDeleteRemote(randomString())
         assertTrue(result is Result.Failure)
     }
 
     @Test
-    fun `shouldDeleteRemote should return Failure for FAILED_PERMANENTLY sync status`() {
+    fun `shouldDeleteRemote should return Success for COMPLETED regular message`() {
         val message = randomMessage(
             type = MessageType.REGULAR,
-            syncStatus = SyncStatus.FAILED_PERMANENTLY,
+            syncStatus = SyncStatus.COMPLETED,
         )
         val result = message.shouldDeleteRemote(randomString())
-        assertTrue(result is Result.Failure)
+        assertTrue(result is Result.Success)
     }
 
     @Test
-    fun `shouldDeleteRemote should return Success for COMPLETED regular message`() {
+    fun `shouldDeleteRemote should return Success for AWAITING_ATTACHMENTS regular message`() {
         val message = randomMessage(
             type = MessageType.REGULAR,
-            syncStatus = SyncStatus.COMPLETED,
+            syncStatus = SyncStatus.AWAITING_ATTACHMENTS,
         )
         val result = message.shouldDeleteRemote(randomString())
         assertTrue(result is Result.Success)
     }
 
     @Test
-    fun `shouldDeleteRemote should return Success for AWAITING_ATTACHMENTS regular message`() {
+    fun `shouldDeleteRemote should return Success for SYNC_NEEDED sync status`() {
         val message = randomMessage(
             type = MessageType.REGULAR,
-            syncStatus = SyncStatus.AWAITING_ATTACHMENTS,
+            syncStatus = SyncStatus.SYNC_NEEDED,
         )
         val result = message.shouldDeleteRemote(randomString())
         assertTrue(result is Result.Success)

stream-chat-android-offline/src/test/java/io/getstream/chat/android/offline/plugin/listener/internal/DeleteMessageListenerDatabaseTest.kt

@@ -209,7 +209,7 @@ internal class DeleteMessageListenerDatabaseTest {
         }
 
     @Test
-    fun `onMessageDeletePrecondition when message has SYNC_NEEDED should return Failure and delete from repo`() =
+    fun `onMessageDeletePrecondition when message has SYNC_NEEDED should return Success`() =
         runTest {
             val currentUser = randomUser()
             val testMessage = randomMessage(
@@ -224,8 +224,7 @@ internal class DeleteMessageListenerDatabaseTest {
 
             val result = deleteMessageListenerState.onMessageDeletePrecondition(testMessage.id)
 
-            assertTrue(result is Result.Failure)
-            verify(messageRepository).deleteChannelMessage(argThat { id == testMessage.id })
+            assertTrue(result is Result.Success)
         }
 
     @Test

stream-chat-android-state/src/test/java/io/getstream/chat/android/state/plugin/listener/internal/DeleteMessageListenerStateTest.kt

@@ -252,7 +252,7 @@ internal class DeleteMessageListenerStateTest {
         }
 
     @Test
-    fun `onMessageDeletePrecondition when message has SYNC_NEEDED should return Failure and delete locally`() =
+    fun `onMessageDeletePrecondition when message has SYNC_NEEDED should return Success`() =
         runTest {
             val testMessage = randomMessage(
                 id = "msg-1",
@@ -262,15 +262,11 @@ internal class DeleteMessageListenerStateTest {
             )
 
             whenever(logicRegistry.channelFromMessageId(any())) doReturn channelLogic
-            whenever(logicRegistry.channelFromMessage(any())) doReturn channelLogic
-            whenever(logicRegistry.getActiveQueryThreadsLogic()) doReturn activeThreadsLogic
-            whenever(logicRegistry.threadFromMessage(any())) doReturn null
             whenever(channelLogic.getMessage(any())) doReturn testMessage
 
             val result = deleteMessageListenerState.onMessageDeletePrecondition(testMessage.id)
 
-            assertTrue(result is Result.Failure)
-            verify(channelLogic).deleteMessage(argThat { id == testMessage.id })
+            assertTrue(result is Result.Success)
         }
 
     @Test