Fix crash when onNext is called on disposed subscription (#6126)

* Fix crash when onNext is called on disposed subscription

Co-Authored-By: Claude <noreply@anthropic.com>

* Update CHANGELOG

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: VelikovPetar

CHANGELOG.md

@@ -13,6 +13,7 @@
 ## stream-chat-android-client
 ### 🐞 Fixed
 - Fix race condition crash when accessing `globalState` during disconnect. [#6122](https://github.com/GetStream/stream-chat-android/pull/6122)
+- Fix crash when `onNext` is called on a disposed subscription. [#6126](https://github.com/GetStream/stream-chat-android/pull/6126)
 
 ### ⬆️ Improved
 

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/utils/observable/Subscriptions.kt

@@ -49,7 +49,7 @@ internal open class SubscriptionImpl(
     }
 
     final override fun onNext(event: ChatEvent) {
-        check(!isDisposed) { "Subscription already disposed, onNext should not be called on it" }
+        if (isDisposed) return
 
         if (filter(event)) {
             try {
@@ -78,7 +78,8 @@ internal class SuspendSubscription(
     }
 
     override fun onNext(event: ChatEvent) {
-        check(!isDisposed) { "Subscription already disposed, onNext should not be called on it" }
+        if (isDisposed) return
+
         scope.launch {
             if (filter(event)) {
                 listener?.onEvent(event)

stream-chat-android-client/src/test/java/io/getstream/chat/android/client/utils/observable/SubscriptionImplTest.kt

@@ -127,19 +127,19 @@ internal class SubscriptionImplTest {
     }
 
     @Test
-    fun `onNext should throw IllegalStateException if subscription is already disposed`() {
+    fun `onNext should not deliver event if subscription is already disposed`() {
+        val mockListener = mock<ChatEventListener<ChatEvent>>()
         val subscription = SubscriptionImpl(
             filter = { true },
-            listener = mock(),
+            listener = mockListener,
         ).apply {
             dispose()
         }
 
         val event = mock<ChatEvent>()
+        subscription.onNext(event)
 
-        assertThrows<IllegalStateException> {
-            subscription.onNext(event)
-        }
+        verify(mockListener, never()).onEvent(event)
     }
 
     @Test