Skip to content

Fix CaptureMediaContract not remembered across recompositions #6169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VelikovPetar merged 1 commit into from
Feb 19, 2026
Merged

Fix CaptureMediaContract not remembered across recompositions #6169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...a/io/getstream/chat/android/compose/ui/messages/attachments/media/CaptureMediaLauncher.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package io.getstream.chat.android.compose.ui.messages.attachments.media
import androidx.activity.compose.ManagedActivityResultLauncher
import androidx.activity.compose.rememberLauncherForActivityResult
import androidx.compose.runtime.Composable
import androidx.compose.runtime.remember
import io.getstream.chat.android.ui.common.contract.internal.CaptureMediaContract
import java.io.File

Expand Down Expand Up @@ -62,8 +63,10 @@ public fun rememberCaptureMediaLauncher(
video: Boolean,
onResult: (File) -> Unit,
): ManagedActivityResultLauncher<Unit, File?>? {
val mode = resolveMediaPickerMode(photo, video) ?: return null
return rememberLauncherForActivityResult(CaptureMediaContract(mode)) { file ->
val contract = remember(photo, video) {
resolveMediaPickerMode(photo, video)?.let { CaptureMediaContract(it) }
} ?: return null
return rememberLauncherForActivityResult(contract) { file ->
file?.let(onResult)
}
}
Expand Down
Loading