Split hold-to-record hint based on audioRecordingSendOnComplete by VelikovPetar · Pull Request #6345 · GetStream/stream-chat-android

VelikovPetar · 2026-04-08T20:06:13Z

Goal

Distinguish between two recording modes in the hold-to-record hint text. When audioRecordingSendOnComplete is true, the hint says "Hold to record. Release to send." When false (default), it says "Hold to record. Release to save."

Implementation

Compose module: Split stream_compose_audio_recording_hint into _hint_send and _hint_save. rememberRecordingHint() picks the correct one based on ChatTheme.config.composer.audioRecordingSendOnComplete.
UI Components module: Split stream_ui_message_composer_hold_to_record into _hold_to_record_send and _hold_to_record_save. MessageComposerViewStyle.audioRecordingHoldToRecordText changed from String to String? — null (default) resolves the text from string resources based on audioRecordingSendOnComplete; non-null acts as a customer override.
Updated Spanish translations, layout XML fallback, styles.xml default, and docs sample.

Testing

Set audioRecordingSendOnComplete = true → tap (don't hold) mic button → hint says "Hold to record. Release to send."
Set audioRecordingSendOnComplete = false (default) → tap mic button → hint says "Hold to record. Release to save."
Set custom audioRecordingHoldToRecordText via StyleTransformer → verify custom text is shown regardless of the flag.

Summary by CodeRabbit

New Features
- Audio recording prompts now provide context-specific guidance with different text displayed based on whether audio will be sent or saved upon release
- Localization support updated across multiple languages to reflect recording action context

Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2026-04-08T20:06:27Z

PR checklist ✅

All required conditions are satisfied:

Title length is OK (or ignored by label).
At least one pr: label exists.
Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

github-actions · 2026-04-08T20:12:01Z

SDK Size Comparison 📏

SDK	Before	After	Difference	Status
stream-chat-android-client	5.25 MB	5.82 MB	0.57 MB	🔴
stream-chat-android-ui-components	10.60 MB	10.96 MB	0.36 MB	🟡
stream-chat-android-compose	12.81 MB	12.25 MB	-0.56 MB	🚀

coderabbitai · 2026-04-08T20:20:14Z

Walkthrough

The changes implement conditional audio recording UI text selection based on the audioRecordingSendOnComplete configuration flag. When enabled, the UI displays "release to send"; otherwise it displays "release to save". This includes logic updates, string resource variants, nullable property changes, and documentation adjustments across the compose and UI component modules.

Changes

Cohort / File(s)	Summary
Compose Audio Recording `AudioRecordingButton.kt`, `compose/.../strings.xml`	Added conditional hint text selection based on `ChatTheme.config.composer.audioRecordingSendOnComplete`. Split single hint string into two variants: `stream_compose_audio_recording_hint_send` and `stream_compose_audio_recording_hint_save`.
UI Components Message Composer Configuration `MessageComposerViewStyle.kt`, `DefaultMessageComposerOverlappingContent.kt`	Made `audioRecordingHoldToRecordText` property nullable (`String?`), enabling dynamic fallback to localized strings based on configuration. Updated display logic to conditionally select between "send" and "save" text variants.
UI Layout & Styles `stream_ui_message_composer_default_center_overlap_floating_hold.xml`, `styles.xml`	Updated layout text reference to `stream_ui_message_composer_hold_to_record_save`. Removed `streamUiMessageComposerAudioRecordingHoldToRecord` style attribute definition to allow runtime text resolution.
String Resources `ui-components/.../values/strings.xml`, `ui-components/.../values-es/strings.xml`	Replaced single `stream_ui_message_composer_hold_to_record` string with two variants: `stream_ui_message_composer_hold_to_record_send` ("Release to send") and `stream_ui_message_composer_hold_to_record_save` ("Release to save") in both English and Spanish.
Documentation `AddingRecordingSupport.kt`	Updated example guide string resource reference from `stream_ui_message_composer_hold_to_record` to `stream_ui_message_composer_hold_to_record_save`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A rabbit's delight in changes so neat,

Where "send" and "save" now both compete!

Null strings spring forth with config's refrain,

Recording prompts dance through compose and UI plain,

Locales now speak in two voices clear! 🎤

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main change: splitting the hold-to-record hint text based on the audioRecordingSendOnComplete configuration flag.
Description check	✅ Passed	The description covers Goal, Implementation, and Testing sections with clear details. However, it's missing UI Changes (before/after screenshots/videos), Contributor Checklist, and Reviewer Checklist sections from the template.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/update_hold_to_record_hints

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@stream-chat-android-docs/src/main/kotlin/io/getstream/chat/docs/kotlin/ui/guides/AddingRecordingSupport.kt`:
- Around line 20-23: The sample hardcodes "save" by overriding
audioRecordingHoldToRecordText in
TransformStyle.messageComposerStyleTransformer, which prevents the SDK from
showing the correct "send" vs "save" copy; instead, remove the hardcoded
override or set audioRecordingHoldToRecordText based on the existing style flag
(defaultStyle.audioRecordingSendOnComplete) or simply preserve
defaultStyle.audioRecordingHoldToRecordText so the built-in send/save selection
remains intact; locate the StyleTransformer assignment
(TransformStyle.messageComposerStyleTransformer and the defaultStyle.copy call)
and either omit the
audioRecordingHoldToRecordText/audioRecordingHoldToRecordTextStyle overrides or
conditionally choose the string from resources based on
defaultStyle.audioRecordingSendOnComplete.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6cae9b93-51d3-4e58-b484-7f3c71ce4e65

📥 Commits

Reviewing files that changed from the base of the PR and between 77a4a20 and 132d7be.

📒 Files selected for processing (9)

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/messages/composer/internal/AudioRecordingButton.kt
stream-chat-android-compose/src/main/res/values/strings.xml
stream-chat-android-docs/src/main/kotlin/io/getstream/chat/docs/kotlin/ui/guides/AddingRecordingSupport.kt
stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/composer/MessageComposerViewStyle.kt
stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/composer/content/DefaultMessageComposerOverlappingContent.kt
stream-chat-android-ui-components/src/main/res/layout/stream_ui_message_composer_default_center_overlap_floating_hold.xml
stream-chat-android-ui-components/src/main/res/values-es/strings.xml
stream-chat-android-ui-components/src/main/res/values/strings.xml
stream-chat-android-ui-components/src/main/res/values/styles.xml

💤 Files with no reviewable changes (1)

stream-chat-android-ui-components/src/main/res/values/styles.xml

...droid-docs/src/main/kotlin/io/getstream/chat/docs/kotlin/ui/guides/AddingRecordingSupport.kt

sonarqubecloud · 2026-04-09T09:35:58Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Split hold-to-record hint text based on audioRecordingSendOnComplete

132d7be

Co-Authored-By: Claude <noreply@anthropic.com>

VelikovPetar added the pr:improvement Improvement label Apr 8, 2026

VelikovPetar added pr:breaking-change Breaking change and removed pr:improvement Improvement labels Apr 8, 2026

VelikovPetar marked this pull request as ready for review April 8, 2026 20:10

VelikovPetar requested a review from a team as a code owner April 8, 2026 20:10

coderabbitai bot reviewed Apr 8, 2026

View reviewed changes

...droid-docs/src/main/kotlin/io/getstream/chat/docs/kotlin/ui/guides/AddingRecordingSupport.kt Show resolved Hide resolved

gpunto approved these changes Apr 9, 2026

View reviewed changes

VelikovPetar merged commit d2cd803 into v7 Apr 9, 2026
23 of 26 checks passed

VelikovPetar deleted the feature/update_hold_to_record_hints branch April 9, 2026 11:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split hold-to-record hint based on audioRecordingSendOnComplete#6345

Split hold-to-record hint based on audioRecordingSendOnComplete#6345
VelikovPetar merged 1 commit intov7from
feature/update_hold_to_record_hints

VelikovPetar commented Apr 8, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

github-actions bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

coderabbitai bot commented Apr 8, 2026

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

VelikovPetar commented Apr 8, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

Implementation

Testing

Summary by CodeRabbit

Uh oh!

github-actions bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist ✅

Uh oh!

github-actions bot commented Apr 8, 2026

SDK Size Comparison 📏

Uh oh!

coderabbitai bot commented Apr 8, 2026

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 9, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

VelikovPetar commented Apr 8, 2026 •

edited by coderabbitai bot

Loading

github-actions bot commented Apr 8, 2026 •

edited

Loading