Skip to content

Register the OkHttp network fetcher explicitly in the default image loader #6384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VelikovPetar merged 2 commits into from
Apr 27, 2026
+15 −0
Merged

Register the OkHttp network fetcher explicitly in the default image loader #6384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
648b2f9
Register the OkHttp network fetcher explicitly to survive R8 full-mode.
andremion Apr 24, 2026
f05d6f6
Test explicit network fetcher registration in StreamImageLoaderFactory
andremion Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...on/src/main/kotlin/io/getstream/chat/android/ui/common/images/StreamImageLoaderFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import coil3.gif.AnimatedImageDecoder
import coil3.gif.GifDecoder
import coil3.intercept.Interceptor
import coil3.memory.MemoryCache
import coil3.network.okhttp.OkHttpNetworkFetcherFactory
import coil3.request.allowHardware
import coil3.request.crossfade
import coil3.video.VideoFrameDecoder
Expand Down Expand Up @@ -82,6 +83,7 @@ public class StreamImageLoaderFactory(
}
.components {
interceptors.forEach { add(it) }
add(OkHttpNetworkFetcherFactory())
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
add(AnimatedImageDecoder.Factory(enforceMinimumFrameDelay = true))
} else {
Expand Down
13 changes: 13 additions & 0 deletions ...rc/test/kotlin/io/getstream/chat/android/ui/common/images/StreamImageLoaderFactoryTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import coil3.disk.DiskCache
import coil3.gif.AnimatedImageDecoder
import coil3.gif.GifDecoder
import coil3.memory.MemoryCache
import coil3.network.NetworkFetcher
import coil3.serviceLoaderEnabled
import coil3.video.VideoFrameDecoder
import okio.Path.Companion.toOkioPath
import org.amshove.kluent.internal.assertEquals
Expand Down Expand Up @@ -103,6 +105,17 @@ internal class StreamImageLoaderFactoryTest {
assertTrue(hasVideoDecoder)
}

@Test
fun `newImageLoader registers network fetcher explicitly without relying on ServiceLoader`() {
val sut = StreamImageLoaderFactory(builder = { serviceLoaderEnabled(false) })

val imageLoader = sut.newImageLoader(context)

val hasNetworkFetcher = imageLoader.components.fetcherFactories
.any { (factory, _) -> factory is NetworkFetcher.Factory }
assertTrue(hasNetworkFetcher)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

@Test
fun `newImageLoader applies custom builder lambda`() {
var customApplied = false
Expand Down
Loading