Skip to content

Scope message cell ripple to the bubble shape #6425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andremion merged 16 commits into from
May 12, 2026
Merged

Scope message cell ripple to the bubble shape #6425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5c1b403
Add ripple feedback to giphy, file, link and quoted-message taps
andremion May 7, 2026
a4df9cd
Move bubble ripple to message-content column-level clickable
andremion May 7, 2026
1743c14
Plumb cell interaction source through to bubble for avatar-gap ripple
andremion May 7, 2026
7023fad
Forward cell click and long-click intents to bubble Column
andremion May 8, 2026
27a3ad1
Rename bubble-mirror callbacks and document why they are hoisted
andremion May 8, 2026
27ed100
Replace bubble-mirror plumbing with non-consuming ripple modifier
andremion May 8, 2026
eec1de1
Ripple text-with-link bubbles on non-link character taps
andremion May 8, 2026
1c1031e
Fix off-by-one and unreachable long-press path in ClickableText
andremion May 8, 2026
ef69663
Extract MessageText interactive-annotation predicates and unit-test them
andremion May 8, 2026
543878c
Cover passiveRipple and the MessageText click dispatch with tests
andremion May 8, 2026
a27e1a2
Tighten MessageText click dispatch and add snapshot coverage
andremion May 8, 2026
990f428
Fire haptic on long-press of link or mention characters
andremion May 11, 2026
fa358d5
Centralize long-press haptic at the message cell entrance
andremion May 11, 2026
0309ae8
spotless
andremion May 11, 2026
ed049dd
Clip quoted-card ripple to the card's rounded shape
andremion May 12, 2026
24cc650
Merge branch 'develop' into fix/sdk-message-cell-ripple-scope
andremion May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion stream-chat-android-compose/api/stream-chat-android-compose.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1504,7 +1504,11 @@ public final class io/getstream/chat/android/compose/ui/components/messages/Comp
public final class io/getstream/chat/android/compose/ui/components/messages/ComposableSingletons$MessageTextKt {
public static final field INSTANCE Lio/getstream/chat/android/compose/ui/components/messages/ComposableSingletons$MessageTextKt;
public fun <init> ()V
public final fun getLambda$-1569101361$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
public final fun getLambda$-261803629$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
public final fun getLambda$-399958751$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
public final fun getLambda$1734337819$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
public final fun getLambda$1973807821$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
public final fun getLambda$552887520$stream_chat_android_compose_release ()Lkotlin/jvm/functions/Function2;
}

public final class io/getstream/chat/android/compose/ui/components/messages/ComposableSingletons$PollMessageContentKt {
Expand Down
3 changes: 2 additions & 1 deletion ...in/java/io/getstream/chat/android/compose/ui/attachments/content/FileAttachmentContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.Text
import androidx.compose.material3.ripple
import androidx.compose.runtime.Composable
import androidx.compose.runtime.remember
import androidx.compose.ui.Alignment
Expand Down Expand Up @@ -111,7 +112,7 @@ public fun FileAttachmentContent(
.background(color, fileAttachmentShape)
}
.combinedClickable(
indication = null,
indication = ripple(),
interactionSource = remember { MutableInteractionSource() },
onClick = { onItemClick(previewHandlers, attachment) },
onLongClick = { attachmentState.onLongItemClick(message) },
Expand Down
3 changes: 2 additions & 1 deletion ...n/java/io/getstream/chat/android/compose/ui/attachments/content/GiphyAttachmentContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.Text
import androidx.compose.material3.ripple
import androidx.compose.runtime.Composable
import androidx.compose.runtime.CompositionLocalProvider
import androidx.compose.runtime.remember
Expand Down Expand Up @@ -123,7 +124,7 @@ public fun GiphyAttachmentContent(
.clip(RoundedCornerShape(StreamTokens.radiusLg))
}
.combinedClickable(
indication = null,
indication = ripple(),
interactionSource = remember { MutableInteractionSource() },
onClick = {
onItemClick(
Expand Down
3 changes: 2 additions & 1 deletion ...in/java/io/getstream/chat/android/compose/ui/attachments/content/LinkAttachmentContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import androidx.compose.foundation.layout.size
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.Icon
import androidx.compose.material3.Text
import androidx.compose.material3.ripple
import androidx.compose.runtime.Composable
import androidx.compose.runtime.CompositionLocalProvider
import androidx.compose.runtime.remember
Expand Down Expand Up @@ -111,7 +112,7 @@ public fun LinkAttachmentContent(
.clip(RoundedCornerShape(StreamTokens.radiusLg))
.background(MessageStyling.attachmentBackgroundColor(state.isMine))
.combinedClickable(
indication = null,
indication = ripple(),
interactionSource = remember { MutableInteractionSource() },
onClick = {
onItemClick(
Expand Down
23 changes: 16 additions & 7 deletions .../src/main/java/io/getstream/chat/android/compose/ui/components/messages/MessageContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,15 @@ import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.Icon
import androidx.compose.material3.Text
import androidx.compose.material3.ripple
import androidx.compose.runtime.Composable
import androidx.compose.runtime.remember
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
Expand Down Expand Up @@ -61,6 +64,7 @@ import io.getstream.chat.android.compose.ui.theme.MessageRegularContentParams
import io.getstream.chat.android.compose.ui.theme.MessageStyling
import io.getstream.chat.android.compose.ui.theme.MessageTextContentParams
import io.getstream.chat.android.compose.ui.theme.StreamTokens
import io.getstream.chat.android.compose.ui.util.passiveRipple
import io.getstream.chat.android.compose.ui.util.shouldBeDisplayedAsFullSizeAttachment
import io.getstream.chat.android.models.Message
import io.getstream.chat.android.models.User
Expand Down Expand Up @@ -179,20 +183,25 @@ internal fun DefaultMessageRegularContent(
) {
val componentFactory = ChatTheme.componentFactory

Column(horizontalAlignment = messageAlignment.contentAlignment) {
Column(
modifier = Modifier.passiveRipple(),
horizontalAlignment = messageAlignment.contentAlignment,
) {
val quotedMessage = message.replyTo
if (quotedMessage != null) {
componentFactory.MessageQuotedContent(
params = MessageQuotedContentParams(
message = quotedMessage,
currentUser = currentUser,
replyMessage = message,
modifier = Modifier.combinedClickable(
interactionSource = remember(::MutableInteractionSource),
indication = null,
onLongClick = { onLongItemClick(message) },
onClick = { onQuotedMessageClick(quotedMessage) },
),
modifier = Modifier
.clip(RoundedCornerShape(StreamTokens.radiusLg))
.combinedClickable(
interactionSource = remember(::MutableInteractionSource),
indication = ripple(),
onLongClick = { onLongItemClick(message) },
onClick = { onQuotedMessageClick(quotedMessage) },
),
),
)
}
Expand Down
Loading
Loading