-
Notifications
You must be signed in to change notification settings - Fork 319
Improve message composer TalkBack accessibility: action verbs, banner merge, audio recording lifecycle #6441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andremion
wants to merge
5
commits into
develop
Choose a base branch
from
fix/compose-composer-a11y
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2e446c0
Add action verbs to composer Send / Save / attach buttons
andremion 625efd7
Merge composer edit/reply banner for a11y
andremion 4b6ddf9
Improve composer audio recording accessibility
andremion da0224f
Consume recording-transition flag only on announce
andremion 0ec78d3
Label audio attachment play / pause button
andremion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
...tstream/chat/android/compose/ui/messages/composer/internal/AudioRecordingAccessibility.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| /* | ||
| * Copyright (c) 2014-2026 Stream.io Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Stream License; | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://github.com/GetStream/stream-chat-android/blob/main/LICENSE | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.getstream.chat.android.compose.ui.messages.composer.internal | ||
|
|
||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.runtime.LaunchedEffect | ||
| import androidx.compose.runtime.getValue | ||
| import androidx.compose.runtime.mutableStateOf | ||
| import androidx.compose.runtime.remember | ||
| import androidx.compose.runtime.setValue | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.platform.LocalView | ||
| import androidx.compose.ui.res.stringResource | ||
| import androidx.compose.ui.semantics.Role | ||
| import androidx.compose.ui.semantics.contentDescription | ||
| import androidx.compose.ui.semantics.role | ||
| import androidx.compose.ui.semantics.semantics | ||
| import io.getstream.chat.android.compose.R | ||
| import io.getstream.chat.android.ui.common.state.messages.composer.RecordingState | ||
|
|
||
| /** | ||
| * Sets the localized content description (which includes the press-and-hold gesture hint) and | ||
| * tags the node as a button so TalkBack announces "Button". | ||
| * | ||
| * The actual recording is started by the press-and-hold gesture on `pointerInput`; lifecycle | ||
| * announcements ("Recording started" / "Recording cancelled") are emitted by | ||
| * [AnnounceRecordingTransitions], not by this modifier. | ||
| */ | ||
| @Composable | ||
| internal fun Modifier.micButtonSemantics(): Modifier { | ||
| val buttonDescription = stringResource(R.string.stream_compose_audio_recording_start) | ||
| return this.semantics { | ||
| contentDescription = buttonDescription | ||
| role = Role.Button | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Observes [recordingState] transitions and emits one-shot TalkBack announcements: | ||
| * - `Idle → Hold` announces "Recording started" | ||
| * - `non-Idle → Idle` announces "Recording cancelled" only when [cancelRequested] is `true` | ||
| * | ||
| * The caller flips [cancelRequested] on when the user invokes a cancel or delete action; this | ||
| * distinguishes a real cancellation from the confirm / send paths, which also transition back | ||
| * to `Idle` but emit through a brief `Complete` state that Compose batches away. | ||
| * | ||
| * @param recordingState Current recording state to observe. | ||
| * @param cancelRequested `true` when the user invoked a cancel or delete action since the last | ||
| * transition was processed. | ||
| * @param onTransitionConsumed Invoked only when a transition is actually announced, so the | ||
| * caller can reset [cancelRequested] to `false`. Transitions that don't result in an | ||
| * announcement leave the flag untouched. | ||
| */ | ||
| @Composable | ||
| internal fun AnnounceRecordingTransitions( | ||
| recordingState: RecordingState, | ||
| cancelRequested: Boolean, | ||
| onTransitionConsumed: () -> Unit, | ||
| ) { | ||
| val view = LocalView.current | ||
| val startedAnnouncement = stringResource(R.string.stream_compose_audio_recording_state_started) | ||
| val cancelledAnnouncement = stringResource(R.string.stream_compose_audio_recording_state_cancelled) | ||
| var previousWasIdle by remember { mutableStateOf(true) } | ||
| val currentIsIdle = recordingState is RecordingState.Idle | ||
| val currentIsHold = recordingState is RecordingState.Hold | ||
|
|
||
| LaunchedEffect(currentIsIdle, currentIsHold) { | ||
| val wasIdle = previousWasIdle | ||
| previousWasIdle = currentIsIdle | ||
| var consumed = false | ||
| when (recordingState) { | ||
| is RecordingState.Hold -> if (wasIdle) { | ||
| view.announceForAccessibility(startedAnnouncement) | ||
| consumed = true | ||
| } | ||
| is RecordingState.Idle -> if (!wasIdle && cancelRequested) { | ||
| view.announceForAccessibility(cancelledAnnouncement) | ||
| consumed = true | ||
| } | ||
| is RecordingState.Locked, | ||
| is RecordingState.Overview, | ||
| is RecordingState.Complete, | ||
| -> Unit | ||
| } | ||
| if (consumed) onTransitionConsumed() | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.