Skip to content

Improve poll vote row TalkBack accessibility #6461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andremion merged 3 commits into from
May 22, 2026
+38 −11
Merged

Improve poll vote row TalkBack accessibility #6461

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf3fb55
Make poll vote rows TalkBack-navigable with merged content
andremion May 21, 2026
299090e
Announce poll vote count with units for TalkBack
andremion May 21, 2026
6d5666d
Merge branch 'develop' into fix/compose-poll-message-item-a11y
andremion May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 38 additions & 11 deletions .../main/java/io/getstream/chat/android/compose/ui/components/messages/PollMessageContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.heightIn
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.selection.toggleable
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.AlertDialog
import androidx.compose.material3.ButtonDefaults
Expand All @@ -50,6 +51,11 @@ import androidx.compose.ui.graphics.StrokeCap
import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.res.pluralStringResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.semantics.clearAndSetSemantics
import androidx.compose.ui.semantics.contentDescription
import androidx.compose.ui.semantics.hideFromAccessibility
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
Expand All @@ -69,6 +75,7 @@ import io.getstream.chat.android.compose.ui.theme.MessageFailedIconParams
import io.getstream.chat.android.compose.ui.theme.MessageStyling
import io.getstream.chat.android.compose.ui.theme.MessageStyling.PollStyle
import io.getstream.chat.android.compose.ui.theme.StreamTokens
import io.getstream.chat.android.compose.ui.util.applyIf
import io.getstream.chat.android.compose.ui.util.isErrorOrFailed
import io.getstream.chat.android.compose.ui.util.passiveRipple
import io.getstream.chat.android.compose.util.extensions.toSet
Expand Down Expand Up @@ -427,23 +434,35 @@ private fun PollOptionItem(
onRemoveVote: () -> Unit,
) {
val typography = ChatTheme.typography
val toggleRole = if (poll.maxVotesAllowed == 1) Role.RadioButton else Role.Checkbox
val onToggle: (Boolean) -> Unit = { enabled ->
val canVote = poll.maxVotesAllowed?.let { checkedCount < it } ?: true
if (enabled && canVote && !checked) {
onCastVote.invoke()
} else if (!enabled) {
onRemoveVote.invoke()
}
}

Row(
modifier = modifier.fillMaxWidth(),
modifier = modifier
.fillMaxWidth()
.applyIf(!poll.closed) {
toggleable(
value = checked,
role = toggleRole,
onValueChange = onToggle,
)
}
.semantics(mergeDescendants = true) {},
horizontalArrangement = Arrangement.spacedBy(StreamTokens.spacingSm),
verticalAlignment = Alignment.CenterVertically,
) {
if (!poll.closed) {
RadioCheck(
modifier = Modifier.semantics { hideFromAccessibility() },
checked = checked,
onCheckedChange = { enabled: Boolean ->
val canVote = poll.maxVotesAllowed?.let { checkedCount < it } ?: true
if (enabled && canVote && !checked) {
onCastVote.invoke()
} else if (!enabled) {
onRemoveVote.invoke()
}
},
onCheckedChange = onToggle,
borderColor = style.outlineColor,
)
}
Expand All @@ -468,8 +487,15 @@ private fun PollOptionItem(
)
}

val voteCountDescription = pluralStringResource(
R.plurals.stream_compose_poll_vote_counts,
voteCount,
voteCount,
)
Text(
modifier = Modifier.align(Alignment.CenterVertically),
modifier = Modifier
.align(Alignment.CenterVertically)
.semantics { contentDescription = voteCountDescription },
text = voteCount.toString(),
style = typography.metadataDefault,
color = style.textColor,
Expand All @@ -488,7 +514,8 @@ private fun PollOptionItem(
modifier = Modifier
.fillMaxWidth()
.height(8.dp)
.clip(RoundedCornerShape(4.dp)),
.clip(RoundedCornerShape(4.dp))
.clearAndSetSemantics {},
progress = { progress },
color = style.progressColor,
trackColor = style.trackColor,
Expand Down
Loading