Merge pull request #626 from GetStream/remove-ne-filter

fix: remove ne filter from user/member query

Author: szuperaz

projects/stream-chat-angular/src/lib/channel.service.spec.ts

@@ -1857,7 +1857,13 @@ describe('ChannelService', () => {
     await init();
     const channel = generateMockChannels(1)[0];
     channel.cid = 'new-channel';
-    spyOn(channel, 'queryMembers').and.callThrough();
+    spyOn(channel, 'queryMembers').and.resolveTo({
+      members: [
+        { user_id: mockCurrentUser().id },
+        { user_id: 'jack' },
+      ] as unknown as ChannelMemberResponse<DefaultStreamChatGenerics>[],
+      duration: '0ms',
+    });
     const users = Array.from({ length: 101 }, (_, i) => ({ id: `${i}` }));
     channel.state.members = {} as any as Record<
       string,

projects/stream-chat-angular/src/lib/channel.service.ts

@@ -1063,9 +1063,11 @@ export class ChannelService<
       }
       const result = await activeChannel.queryMembers({
         name: { $autocomplete: searchTerm },
-        id: { $ne: this.chatClientService.chatClient.userID! },
       } as UserFilters<T>); // TODO: find out why we need typecast here
-      return Object.values(result.members);
+
+      return result.members.filter(
+        (m) => m.user_id !== this.chatClientService.chatClient?.user?.id
+      );
     }
   }
 

projects/stream-chat-angular/src/lib/chat-client.service.spec.ts

@@ -319,8 +319,15 @@ describe('ChatClientService', () => {
     expect(mockChatClient.flagMessage).toHaveBeenCalledWith('messageId');
   });
 
-  it('should query members', async () => {
-    mockChatClient.queryUsers.and.returnValue({ users: [{}, {}] });
+  it('should query users', async () => {
+    mockChatClient.queryUsers.and.returnValue({
+      users: [
+        {
+          id: mockCurrentUser().id,
+        },
+        { id: 'zizi' },
+      ],
+    });
     const result = await service.autocompleteUsers('zi');
 
     expect(mockChatClient.queryUsers).toHaveBeenCalledWith(
@@ -332,7 +339,7 @@ describe('ChatClientService', () => {
       })
     );
 
-    expect(result.length).toBe(2);
+    expect(result.length).toBe(1);
   });
 
   it('should initialize pending invites', async () => {

projects/stream-chat-angular/src/lib/chat-client.service.ts

@@ -230,9 +230,8 @@ export class ChatClientService<
         { id: { $autocomplete: searchTerm } },
         { name: { $autocomplete: searchTerm } },
       ],
-      id: { $ne: this.chatClient.userID! },
     } as UserFilters<T>); // TODO: find out why we need this typecast
-    return result.users;
+    return result.users.filter((u) => u.id !== this.chatClient?.user?.id);
   }
 
   private updatePendingInvites(e: Event<T>) {

projects/stream-chat-angular/src/lib/mocks/index.ts

@@ -188,6 +188,11 @@ export const generateMockChannels = (length = 25) => {
               id: 'jack',
             },
           },
+          john: {
+            user: {
+              id: 'john',
+            },
+          },
         },
       }),
       getConfig: () => ({