docs(ui)!: correct migration docs; remove dead MessageDetails#2680
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
migrations/redesign/message_composer.md (1)
421-422:⚠️ Potential issue | 🟠 Major | ⚡ Quick winFix
slowModeOnLabelusage in migration snippet (missingcooldownTimeOut).In
migrations/redesign/message_composer.md(lines 421-422), the example usestranslations.slowModeOnLabelwithout the requiredint cooldownTimeOut. The SDK definesslowModeOnLabel(int cooldownTimeOut), so copy-pasting this will fail.Suggested doc fix
- SlowModePlaceholder() => translations.slowModeOnLabel, + SlowModePlaceholder(:final cooldownTimeOut) => + translations.slowModeOnLabel(cooldownTimeOut),🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@migrations/redesign/message_composer.md` around lines 421 - 422, The migration snippet uses translations.slowModeOnLabel without the required integer argument; update the example so SlowModePlaceholder calls translations.slowModeOnLabel with a concrete int (e.g., translations.slowModeOnLabel(30)) or a named variable such as cooldownTimeOut, ensuring the signature slowModeOnLabel(int cooldownTimeOut) is satisfied in the example in message_composer.md where SlowModePlaceholder is shown.migrations/redesign/message_actions.md (1)
236-265:⚠️ Potential issue | 🟠 Major | ⚡ Quick winReplace stale
StreamMessageReactionsModalexamples after declaring it deleted.This section says the class is deleted, but the “After” snippet still constructs
StreamMessageReactionsModal, and Line 480 still lists it as a return-value source. That makes the migration path self-contradictory and likely leads to compile errors for readers following it.Proposed doc fix
-### StreamMessageReactionsModal +### StreamMessageReactionsModal → ReactionDetailSheet @@ -**After:** +**After:** ```dart -final action = await showStreamDialog<MessageAction>( - context: context, - builder: (_) => StreamMessageReactionsModal( - message: message, - messageWidget: messageWidget, - ), -); +final action = await ReactionDetailSheet.show( + context: context, + message: message, +); if (action is SelectReaction) { _addReaction(action.reaction); }@@
-- ReturnsFuture<T?>— the value passed toNavigator.popinside the dialog, which is howStreamMessageActionsModal,StreamMessageReactionsModal, andModeratedMessageActionsModaldeliver the selected action back to the caller
+- ReturnsFuture<T?>— the value passed toNavigator.popinside the dialog, which is howStreamMessageActionsModalandModeratedMessageActionsModaldeliver the selected action back to the caller</details> Also applies to: 480-480 <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In
@migrations/redesign/message_actions.mdaround lines 236 - 265, Update the
migration docs to stop referencing the deleted StreamMessageReactionsModal:
replace the "After" example that still calls StreamMessageReactionsModal with a
call to ReactionDetailSheet.show(...) (passing context and message) and await
its MessageAction result via showStreamDialog/ReactionDetailSheet.show; then
adjust the Returns description to remove StreamMessageReactionsModal from the
list of dialogs that return Future<T?> so it only mentions
StreamMessageActionsModal and ModeratedMessageActionsModal; keep references to
SelectReaction and MessageAction so readers know how to handle the returned
action.</details> </blockquote></details> </blockquote></details>🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Inline comments: In `@migrations/redesign/attachments_and_polls.md`: - Line 300: The migration doc contains inconsistent anchors for the redesigned attachment picker link — replace the stale `#streamattachmentpickeroption` anchor in the sentence referencing `AttachmentModalSheet` and `showStreamAttachmentPickerModalBottomSheet` with the confirmed `#attachment-picker` anchor (the same used elsewhere in the document) so the link points to the correct section; update the link target text to match the existing anchor name to avoid broken docs links. In `@migrations/redesign/unread_indicator_button.md`: - Around line 31-35: The migration note is ambiguous about which callback was renamed; update the text to explicitly state that only onTap was renamed to onJumpTap while onDismissTap remains unchanged (or change the section heading from "callback renames" to "callback rename" and add a clarifying sentence). Reference the callback names onTap, onJumpTap, and onDismissTap so readers clearly understand that onTap → onJumpTap is the only change. In `@migrations/v10-migration.md`: - Line 1054: Update the stable-range version boundary wording so it matches the upgrade matrix/timeline: change the reference from "beta.13" to "beta.12" in the migration note that currently reads "The following breaking changes landed between beta.13 and the stable release" so that it correctly routes v10.0.0-beta.12 users to this section; ensure the adjacent sentence/context that mentions the timeline/upgrade matrix uses the same "beta.12" boundary to avoid conflicting migration guidance. --- Outside diff comments: In `@migrations/redesign/message_actions.md`: - Around line 236-265: Update the migration docs to stop referencing the deleted StreamMessageReactionsModal: replace the "After" example that still calls StreamMessageReactionsModal with a call to ReactionDetailSheet.show(...) (passing context and message) and await its MessageAction result via showStreamDialog/ReactionDetailSheet.show; then adjust the Returns description to remove StreamMessageReactionsModal from the list of dialogs that return Future<T?> so it only mentions StreamMessageActionsModal and ModeratedMessageActionsModal; keep references to SelectReaction and MessageAction so readers know how to handle the returned action. In `@migrations/redesign/message_composer.md`: - Around line 421-422: The migration snippet uses translations.slowModeOnLabel without the required integer argument; update the example so SlowModePlaceholder calls translations.slowModeOnLabel with a concrete int (e.g., translations.slowModeOnLabel(30)) or a named variable such as cooldownTimeOut, ensuring the signature slowModeOnLabel(int cooldownTimeOut) is satisfied in the example in message_composer.md where SlowModePlaceholder is shown.🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID:
821e3ca9-d434-40a8-9168-61239f3ed41c📒 Files selected for processing (18)
migrations/redesign/README.mdmigrations/redesign/attachments_and_polls.mdmigrations/redesign/audio_theme.mdmigrations/redesign/channel_list_item.mdmigrations/redesign/headers_and_icons.mdmigrations/redesign/image_cdn.mdmigrations/redesign/localizations.mdmigrations/redesign/media_viewer.mdmigrations/redesign/message_actions.mdmigrations/redesign/message_composer.mdmigrations/redesign/message_list.mdmigrations/redesign/message_widget.mdmigrations/redesign/reaction_list.mdmigrations/redesign/reaction_picker.mdmigrations/redesign/stream_avatar.mdmigrations/redesign/unread_indicator.mdmigrations/redesign/unread_indicator_button.mdmigrations/v10-migration.md
renefloor
force-pushed
the
docs/update-migration-docs
branch
from
f325292 to
5aa1043
Compare
renefloor
force-pushed
the
docs/update-migration-docs
branch
from
5aa1043 to
8b051a4
Compare
Apply ~70+ corrections across all 16 redesign migration docs and v10-migration.md based on a source-by-source verification pass. Fixes non-existent symbols, wrong constructor params, wrong typedef signatures, and stale class names that would prevent migration code examples from compiling. Adds the missing ClientState collection immutability breaking-change section (introduced in 2501f53). Also cleans up five stale dartdoc references in source that seeded some of the wrong names in the docs (StreamMessagePlacement → StreamMessageLayout, UrlAttachmentBuilder → LinkPreviewAttachmentBuilder, StreamChat(config:) → streamChatConfigData:, etc.). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The MessageDetails class was only used by itself — no live consumers in packages/ or sample_app. The new messageBuilder signature stopped passing it as an argument, leaving the class as dead public surface area. Delete the file and its export; update CHANGELOG and the migration doc that previously said "no longer passed to builders" to reflect the actual removal. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The two avatar theme types live in stream_core_flutter, but consumers who only depended on stream_chat_flutter had to add a second import to theme avatars globally. Add them to the show allowlist so existing StreamAvatarThemeData imports keep working, drop the now-redundant stream_core_flutter import from stream_media_gallery_item.dart, and update the migration doc that previously instructed users to import from stream_core_flutter directly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…file stream_attachment_picker_bottom_sheet.dart only held the AttachmentPickerOptionsBuilder typedef — the filename implied a sheet class that no longer exists after pickers became inline. Move the typedef into stream_attachment_picker.dart (next to the picker widgets and builder functions that use it) and delete the misleading file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Front-load the two-layer split so future doc passes don't conflate "moved to stream_core_flutter" with "removed." Includes a small core-primitive ↔ chat-wrapper table and a "frequently confused names" list covering the wrong-name patterns that surfaced during the verification pass (StreamMessagePlacement → StreamMessageLayout, kStreamHeaderHeight → kStreamToolbarHeight, etc.). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- attachments_and_polls.md: fix stale #streamattachmentpickeroption anchor (→ #attachment-picker) and drop reference to the removed showStreamAttachmentPickerModalBottomSheet function. - v10-migration.md: stable-release boundary was beta.12, not beta.13 (matches the upgrade matrix at the top of the doc). - message_actions.md: drop StreamMessageReactionsModal from the showStreamDialog Future<T?> "returns" list — the class is deleted. - message_composer.md: destructure cooldownTimeOut from SlowModePlaceholder so translations.slowModeOnLabel(int) gets its required argument; matches the source dartdoc example verbatim. The fourth flagged comment (onDismissTap row in unread_indicator_button.md) was already removed in the earlier verification pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
xsahil03x
changed the title
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
migrations/v10-migration.md (1)
981-981:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix version boundary to align with migration path table.
Line 981 states "between beta.13 and the stable release," but line 52 routes v10.0.0-beta.12 users to this section. This creates confusion about which beta version marks the boundary for stable-release changes.
📝 Align the version boundary
-The following breaking changes landed between beta.13 and the stable release. +The following breaking changes landed between beta.12 and the stable release.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@migrations/v10-migration.md` at line 981, Update the version boundary text so it matches the migration path table: change the sentence that currently reads "between beta.13 and the stable release" to reference the same beta shown in the migration routing (v10.0.0-beta.12), or adjust the migration table to route v10.0.0-beta.13 to this section—specifically edit the sentence containing "between beta.13 and the stable release" and/or the routing line referencing "v10.0.0-beta.12" so both reference the same beta version.
🧹 Nitpick comments (1)
migrations/redesign/message_widget.md (1)
353-358: 💤 Low valueOptional: Consider rewording to avoid repetition.
Three successive sentences begin with "For", which slightly impacts readability. Consider varying the sentence structure:
For attachment-related removals (`StreamFileAttachmentThumbnail`, `StreamAttachmentUploadStateBuilder.successBuilder`, etc.), see [attachments_and_polls.md](attachments_and_polls.md). -For composer-related removals (`AttachmentButton`, `StreamQuotedMessageWidget`, `EditMessageSheet`, `StreamMessageSendButton`, etc.), see [message_composer.md](message_composer.md). +Composer-related removals (`AttachmentButton`, `StreamQuotedMessageWidget`, `EditMessageSheet`, `StreamMessageSendButton`, etc.) are documented in [message_composer.md](message_composer.md). -For reactions-related removals (`DesktopReactionsBuilder`, `StreamMessageReactionsModal`), see [reaction_list.md](reaction_list.md) and [message_actions.md](message_actions.md). +Reactions-related removals (`DesktopReactionsBuilder`, `StreamMessageReactionsModal`) are covered in [reaction_list.md](reaction_list.md) and [message_actions.md](message_actions.md).As per static analysis hint: Three successive sentences begin with the same word (ENGLISH_WORD_REPEAT_BEGINNING_RULE).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@migrations/redesign/message_widget.md` around lines 353 - 358, The three successive sentences that begin with "For" are repetitive; consolidate and rephrase them to improve readability by either merging into one sentence or varying their openings—e.g., "See attachments_and_polls.md for attachment-related removals such as StreamFileAttachmentThumbnail and StreamAttachmentUploadStateBuilder.successBuilder; see message_composer.md for composer-related removals like AttachmentButton, StreamQuotedMessageWidget, EditMessageSheet, and StreamMessageSendButton; and see reaction_list.md and message_actions.md for reactions-related removals such as DesktopReactionsBuilder and StreamMessageReactionsModal." Ensure the referenced symbols (StreamFileAttachmentThumbnail, StreamAttachmentUploadStateBuilder.successBuilder, AttachmentButton, StreamQuotedMessageWidget, EditMessageSheet, StreamMessageSendButton, DesktopReactionsBuilder, StreamMessageReactionsModal) and target docs (attachments_and_polls.md, message_composer.md, reaction_list.md, message_actions.md) remain included.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@migrations/redesign/reaction_picker.md`:
- Around line 22-33: The document contains a spelling inconsistency: the entry
for `StreamReactionPickerTheme` / `StreamReactionPickerThemeData` uses British
spelling "customisation" while elsewhere (e.g., the "Customization" heading)
uses American spelling; update that entry to use "Customization" so the term
matches the rest of the doc (keep the rest of the sentence intact: "theme-based
visual Customization for the picker") and ensure `StreamReactionPickerTheme` /
`StreamReactionPickerThemeData` remains unchanged otherwise.
---
Duplicate comments:
In `@migrations/v10-migration.md`:
- Line 981: Update the version boundary text so it matches the migration path
table: change the sentence that currently reads "between beta.13 and the stable
release" to reference the same beta shown in the migration routing
(v10.0.0-beta.12), or adjust the migration table to route v10.0.0-beta.13 to
this section—specifically edit the sentence containing "between beta.13 and the
stable release" and/or the routing line referencing "v10.0.0-beta.12" so both
reference the same beta version.
---
Nitpick comments:
In `@migrations/redesign/message_widget.md`:
- Around line 353-358: The three successive sentences that begin with "For" are
repetitive; consolidate and rephrase them to improve readability by either
merging into one sentence or varying their openings—e.g., "See
attachments_and_polls.md for attachment-related removals such as
StreamFileAttachmentThumbnail and
StreamAttachmentUploadStateBuilder.successBuilder; see message_composer.md for
composer-related removals like AttachmentButton, StreamQuotedMessageWidget,
EditMessageSheet, and StreamMessageSendButton; and see reaction_list.md and
message_actions.md for reactions-related removals such as
DesktopReactionsBuilder and StreamMessageReactionsModal." Ensure the referenced
symbols (StreamFileAttachmentThumbnail,
StreamAttachmentUploadStateBuilder.successBuilder, AttachmentButton,
StreamQuotedMessageWidget, EditMessageSheet, StreamMessageSendButton,
DesktopReactionsBuilder, StreamMessageReactionsModal) and target docs
(attachments_and_polls.md, message_composer.md, reaction_list.md,
message_actions.md) remain included.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 29c039d8-7f8b-4bbc-b15e-75afa469fe9d
📒 Files selected for processing (29)
migrations/redesign/README.mdmigrations/redesign/attachments_and_polls.mdmigrations/redesign/audio_theme.mdmigrations/redesign/channel_list_item.mdmigrations/redesign/headers_and_icons.mdmigrations/redesign/image_cdn.mdmigrations/redesign/localizations.mdmigrations/redesign/media_viewer.mdmigrations/redesign/message_actions.mdmigrations/redesign/message_composer.mdmigrations/redesign/message_list.mdmigrations/redesign/message_widget.mdmigrations/redesign/reaction_list.mdmigrations/redesign/reaction_picker.mdmigrations/redesign/stream_avatar.mdmigrations/redesign/unread_indicator.mdmigrations/redesign/unread_indicator_button.mdmigrations/v10-migration.mdpackages/stream_chat_flutter/CHANGELOG.mdpackages/stream_chat_flutter/lib/src/attachment/builder/attachment_widget_builder.dartpackages/stream_chat_flutter/lib/src/attachment/link_preview_attachment.dartpackages/stream_chat_flutter/lib/src/media_gallery/stream_media_gallery_item.dartpackages/stream_chat_flutter/lib/src/message_input/attachment_picker/stream_attachment_picker.dartpackages/stream_chat_flutter/lib/src/message_input/attachment_picker/stream_attachment_picker_bottom_sheet.dartpackages/stream_chat_flutter/lib/src/message_list_view/message_details.dartpackages/stream_chat_flutter/lib/src/message_list_view/message_list_view.dartpackages/stream_chat_flutter/lib/src/message_modal/message_actions_modal.dartpackages/stream_chat_flutter/lib/src/utils/stream_image_cdn.dartpackages/stream_chat_flutter/lib/stream_chat_flutter.dart
💤 Files with no reviewable changes (4)
- packages/stream_chat_flutter/lib/src/media_gallery/stream_media_gallery_item.dart
- packages/stream_chat_flutter/lib/src/message_input/attachment_picker/stream_attachment_picker_bottom_sheet.dart
- packages/stream_chat_flutter/lib/src/message_list_view/message_details.dart
- packages/stream_chat_flutter/lib/src/attachment/link_preview_attachment.dart
✅ Files skipped from review due to trivial changes (13)
- packages/stream_chat_flutter/lib/src/attachment/builder/attachment_widget_builder.dart
- packages/stream_chat_flutter/lib/src/message_list_view/message_list_view.dart
- packages/stream_chat_flutter/lib/src/message_modal/message_actions_modal.dart
- packages/stream_chat_flutter/lib/src/utils/stream_image_cdn.dart
- migrations/redesign/stream_avatar.md
- migrations/redesign/unread_indicator_button.md
- migrations/redesign/channel_list_item.md
- migrations/redesign/message_list.md
- migrations/redesign/media_viewer.md
- migrations/redesign/reaction_list.md
- migrations/redesign/localizations.md
- migrations/redesign/message_actions.md
- migrations/redesign/attachments_and_polls.md
🚧 Files skipped from review as they are similar to previous changes (1)
- migrations/redesign/message_composer.md
Line 31 used British "customisation" while the rest of the doc (and the heading at line 299) uses American "Customization". Match the rest. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
xsahil03x
approved these changes
May 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v10.0.0 #2680 +/- ##
===========================================
+ Coverage 67.06% 67.07% +0.01%
===========================================
Files 408 407 -1
Lines 24432 24428 -4
===========================================
Hits 16385 16385
+ Misses 8047 8043 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@migrations/redesign/message_widget.md`:
- Line 168: Update the stale symbol reference: replace the
`StreamMessagePlacement` mention for the `reverse` entry with
`StreamMessageLayout` so it matches the rest of the redesign docs and existing
uses of `StreamMessageLayout` (i.e., change the `reverse` description that
currently reads "Determined by `StreamMessagePlacement` context..." to
"Determined by `StreamMessageLayout` context...").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d8cf598c-a3b5-439e-a28d-a14a41a7e79c
📒 Files selected for processing (29)
migrations/redesign/README.mdmigrations/redesign/attachments_and_polls.mdmigrations/redesign/audio_theme.mdmigrations/redesign/channel_list_item.mdmigrations/redesign/headers_and_icons.mdmigrations/redesign/image_cdn.mdmigrations/redesign/localizations.mdmigrations/redesign/media_viewer.mdmigrations/redesign/message_actions.mdmigrations/redesign/message_composer.mdmigrations/redesign/message_list.mdmigrations/redesign/message_widget.mdmigrations/redesign/reaction_list.mdmigrations/redesign/reaction_picker.mdmigrations/redesign/stream_avatar.mdmigrations/redesign/unread_indicator.mdmigrations/redesign/unread_indicator_button.mdmigrations/v10-migration.mdpackages/stream_chat_flutter/CHANGELOG.mdpackages/stream_chat_flutter/lib/src/attachment/builder/attachment_widget_builder.dartpackages/stream_chat_flutter/lib/src/attachment/link_preview_attachment.dartpackages/stream_chat_flutter/lib/src/media_gallery/stream_media_gallery_item.dartpackages/stream_chat_flutter/lib/src/message_input/attachment_picker/stream_attachment_picker.dartpackages/stream_chat_flutter/lib/src/message_input/attachment_picker/stream_attachment_picker_bottom_sheet.dartpackages/stream_chat_flutter/lib/src/message_list_view/message_details.dartpackages/stream_chat_flutter/lib/src/message_list_view/message_list_view.dartpackages/stream_chat_flutter/lib/src/message_modal/message_actions_modal.dartpackages/stream_chat_flutter/lib/src/utils/stream_image_cdn.dartpackages/stream_chat_flutter/lib/stream_chat_flutter.dart
💤 Files with no reviewable changes (4)
- packages/stream_chat_flutter/lib/src/attachment/link_preview_attachment.dart
- packages/stream_chat_flutter/lib/src/media_gallery/stream_media_gallery_item.dart
- packages/stream_chat_flutter/lib/src/message_input/attachment_picker/stream_attachment_picker_bottom_sheet.dart
- packages/stream_chat_flutter/lib/src/message_list_view/message_details.dart
✅ Files skipped from review due to trivial changes (15)
- packages/stream_chat_flutter/lib/src/message_modal/message_actions_modal.dart
- migrations/redesign/stream_avatar.md
- packages/stream_chat_flutter/lib/src/message_list_view/message_list_view.dart
- packages/stream_chat_flutter/CHANGELOG.md
- packages/stream_chat_flutter/lib/src/attachment/builder/attachment_widget_builder.dart
- migrations/redesign/media_viewer.md
- packages/stream_chat_flutter/lib/src/utils/stream_image_cdn.dart
- migrations/redesign/message_list.md
- packages/stream_chat_flutter/lib/src/message_input/attachment_picker/stream_attachment_picker.dart
- migrations/redesign/unread_indicator_button.md
- migrations/redesign/audio_theme.md
- migrations/redesign/channel_list_item.md
- migrations/redesign/attachments_and_polls.md
- migrations/redesign/reaction_list.md
- migrations/redesign/localizations.md
🚧 Files skipped from review as they are similar to previous changes (1)
- migrations/redesign/message_composer.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description
Source-by-source verification pass across all 16 redesign migration docs plus
v10-migration.md. Reworks ~70+ inaccuracies that would prevent migration code examples from compiling (wrong typedef signatures, non-existent classes, stale class names, wrong constructor params), and adds the previously-missingClientStatecollection immutability breaking-change section.Recurring themes corrected
StreamMessagePlacement→StreamMessageLayout(5+ docs)kStreamHeaderHeight→kStreamToolbarHeight(3+ places)StreamMessageReactionsModal(removed) →ReactionDetailSheetMessageComposerInputProps"rename" clarified as a splitStream*AttachmentPickerBottomSheetclasses don't exist)failedBuilder/preparingBuilder/inProgressBuildercorrected to matchlib/src/utils/typedefs.dartmessageWidget:→messageItem:factory builder keyAdjacent code cleanup (surfaced by the verification)
MessageDetailsclass — no live consumers; alignment viaStreamMessageLayout.of(context), user viaStreamChat.of(context). Breaking.StreamAvatarTheme/StreamAvatarThemeDatafromstream_core_flutterso existing avatar-theming imports keep working without a separatestream_core_flutterimport.AttachmentPickerOptionsBuildertypedef intostream_attachment_picker.dartand deleted the empty, misleadingly-namedstream_attachment_picker_bottom_sheet.dart.StreamMessagePlacement→StreamMessageLayout,[UrlAttachmentBuilder]→[LinkPreviewAttachmentBuilder],StreamChat(config:)→streamChatConfigData:, etc.).Stream Core / Stream Chat preamble
Added a short two-layer-split note to
migrations/redesign/README.mdso future doc passes don't conflate "moved tostream_core_flutter" with "removed".Review feedback
All actionable comments from the CodeRabbit review have been addressed (anchor fix,
beta.13→beta.12,slowModeOnLabel(cooldownTimeOut), removed staleStreamMessageReactionsModalfromshowStreamDialogreturn-list).Summary by CodeRabbit
Documentation
Chores
MessageDetailsclass; useStreamChat.of(context).currentUserandStreamMessageLayout.of(context)instead.