fix(persistence): Ensure messageLimit is respected in getChannelStates#2717
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v10.0.0 #2717 +/- ##
========================================
Coverage 67.55% 67.55%
========================================
Files 408 408
Lines 24521 24522 +1
========================================
+ Hits 16565 16566 +1
Misses 7956 7956 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Submit a pull request
CLA
Description of the pull request
The
messageLimithandling in theStreamChatPersistenceClient#getChannelStateswas lost, most likely when mergingmaster(with DB read optimisations) intov10.0.0. This PR restores the logic for forwarding themessageLimitto thegetChannelStateByCidmethod.Screenshots / Videos
NA
Summary by CodeRabbit