Skip to content

Commit 0bef74f

Browse files
committed
fix: failing tests
1 parent 8c95096 commit 0bef74f

File tree

5 files changed

+89
-131
lines changed

5 files changed

+89
-131
lines changed

package/src/components/Attachment/ImageLoadingIndicator.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ export const ImageLoadingIndicator = () => {
1010
} = useTheme();
1111
return (
1212
<NativeShimmerView
13+
accessibilityLabel='Image Loading Indicator'
14+
accessible
1315
enabled
1416
gradientColor={semantics.skeletonLoadingHighlight}
1517
style={StyleSheet.absoluteFillObject}

package/src/components/Attachment/__tests__/Gallery.test.js

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
import React from 'react';
22

3-
import {
4-
fireEvent,
5-
render,
6-
screen,
7-
waitFor,
8-
waitForElementToBeRemoved,
9-
} from '@testing-library/react-native';
3+
import { fireEvent, render, screen, waitFor } from '@testing-library/react-native';
104

115
import { OverlayProvider } from '../../../contexts/overlayContext/OverlayProvider';
126

@@ -288,11 +282,15 @@ describe('Gallery', () => {
288282
expect(screen.queryAllByTestId('gallery-container').length).toBe(1);
289283
});
290284

291-
fireEvent(screen.getByLabelText('Gallery Image'), 'onLoadStart');
292-
expect(screen.getByLabelText('Image Loading Indicator')).toBeTruthy();
285+
fireEvent(screen.getByLabelText('Gallery Image'), 'loadStart');
286+
await waitFor(() => {
287+
expect(screen.getByLabelText('Image Loading Indicator')).toBeTruthy();
288+
});
293289

294-
fireEvent(screen.getByLabelText('Gallery Image'), 'onLoadFinish');
295-
waitForElementToBeRemoved(() => screen.getByLabelText('Image Loading Indicator'));
290+
fireEvent(screen.getByLabelText('Gallery Image'), 'loadEnd');
291+
await waitFor(() => {
292+
expect(screen.queryByLabelText('Image Loading Indicator')).toBeNull();
293+
});
296294
expect(screen.getByLabelText('Gallery Image')).toBeTruthy();
297295
});
298296
});

package/src/components/Attachment/__tests__/Giphy.test.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import {
88
screen,
99
userEvent,
1010
waitFor,
11-
waitForElementToBeRemoved,
1211
} from '@testing-library/react-native';
1312

1413
import { MessageProvider } from '../../../contexts/messageContext/MessageContext';
@@ -335,23 +334,21 @@ describe('Giphy', () => {
335334
</Chat>
336335
</OverlayProvider>,
337336
);
338-
await waitFor(() => {
339-
expect(screen.getByLabelText('Image Loading Indicator')).toBeTruthy();
340-
});
341-
342337
act(() => {
343-
fireEvent(screen.getByLabelText('Giphy Attachment Image'), 'onLoadStart');
338+
fireEvent(screen.getByLabelText('Giphy Attachment Image'), 'loadStart');
344339
});
345340

346341
await waitFor(() => {
347342
expect(screen.getByLabelText('Image Loading Indicator')).toBeTruthy();
348343
});
349344

350345
act(() => {
351-
fireEvent(screen.getByLabelText('Giphy Attachment Image'), 'onLoad');
346+
fireEvent(screen.getByLabelText('Giphy Attachment Image'), 'loadEnd');
352347
});
353348

354-
waitForElementToBeRemoved(() => screen.getByLabelText('Image Loading Indicator'));
349+
await waitFor(() => {
350+
expect(screen.queryByLabelText('Image Loading Indicator')).toBeNull();
351+
});
355352

356353
await waitFor(() => {
357354
expect(screen.getByLabelText('Giphy Attachment Image')).toBeTruthy();

package/src/components/Message/MessageSimple/__tests__/__snapshots__/MessageTextContainer.test.tsx.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ exports[`MessageTextContainer should render message text container 1`] = `
66
[
77
{
88
"maxWidth": 256,
9+
"paddingHorizontal": 12,
910
},
1011
{},
1112
undefined,

0 commit comments

Comments
 (0)