Skip to content

Commit 471c31a

Browse files
committed
fix: cleanup
1 parent fa1546f commit 471c31a

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

package/src/components/Message/hooks/useMessageActionHandlers.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,9 @@ export const useMessageActionHandlers = ({
124124
}
125125
});
126126

127-
const setEditingMessage = useStableCallback((messageToEdit: LocalMessage = message) => {
128-
setEditingState(messageToEdit);
127+
const handleEditMessage = useWithPortalKeyboardSafety(() => {
128+
setEditingState(message);
129129
});
130-
const handleEditMessage = useWithPortalKeyboardSafety(setEditingMessage);
131130

132131
const handleFlagMessage = useStableCallback(() => {
133132
if (!message.id) {

package/src/hooks/useAfterKeyboardOpenCallback.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ export const useAfterKeyboardOpenCallback = <T extends unknown[]>(
2121
const isKeyboardVisible = useKeyboardVisibility();
2222
const { inputBoxRef } = useMessageInputContext();
2323
const keyboardSubscriptionRef = useRef<EventSubscription | undefined>(undefined);
24+
// This callback runs from a keyboard event listener, so it must stay fresh across rerenders.
2425
const stableCallback = useStableCallback(callback);
2526

2627
/** Clears the pending keyboard listener, if any. */

package/src/hooks/usePortalSettledCallback.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ const scheduleAfterFrames = (callback: () => void, frames: number, rafIds: numbe
6161
*/
6262
export const usePortalSettledCallback = <T extends unknown[]>(callback: (...args: T) => void) => {
6363
const rafIdsRef = useRef<number[]>([]);
64+
// This callback runs from deferred RAF work, so it must stay fresh across rerenders.
6465
const stableCallback = useStableCallback(callback);
6566

6667
const clearScheduledFrames = useStableCallback(() => {

0 commit comments

Comments
 (0)