chore(lint): drop @react-native/eslint-config, bump @shopify/flash-list

Two related peer-warning fixes:

1) @shopify/flash-list -- examples/ExpoMessaging pinned 2.0.2 while
   core's peerDependency required >=2.1.0. Bump every workspace to a
   2.3.x baseline:
   - examples/ExpoMessaging: 2.0.2 -> ^2.3.1
   - examples/SampleApp: ^2.1.0 -> ^2.3.1
   - package (peer): >=2.1.0 -> >=2.3.0
   - package (devDep): ^2.1.0 -> ^2.3.1

2) @react-native/eslint-config (and its companion -plugin) -- drop
   both entirely. The config contributed:
   - No @react-native/* rules of its own (the plugin was unused).
   - ~120 mostly-default rule levels that overlap with what we already
     get from @eslint/js.recommended, tsEslint.configs.recommended and
     eslintPluginReact.configs.flat.recommended.
   - 43 globals, all but one (__DEV__) covered by the standard
     `globals` package presets (browser + node + es2021).

   The bundled @typescript-eslint/eslint-plugin@7.18.0 it dragged in
   was also the source of an "eslint 9.39.4 doesn't satisfy ^8.57.0"
   peer warning -- gone now that the package is removed.

   What changes in our config:
   - Replace dynamic globals/rules extraction with explicit values:
     globals.browser + globals.node + globals.es2021 + __DEV__.
   - Replace `...reactNativeRules` spread with explicit rule
     declarations. Behavior preserved for everything our codebase
     touches; a handful of recommended-preset rules
     (no-constant-condition, no-empty, no-inner-declarations,
     no-redeclare, react/display-name, react/no-unknown-property,
     react/react-in-jsx-scope) are silenced explicitly to match the
     prior state.
   - Re-enable three rules at `warn` that the RN config had on and
     that catch real footguns: react/no-unstable-nested-components,
     no-bitwise, no-extend-native. Keeps existing eslint-disable
     directives in example apps valid.
   - Fix the React-version warning placement: settings are now a
     standalone top-level config object so they cover
     eslintPluginReact.configs.flat.recommended (previously they only
     applied to the 'default' overlay, so the warning kept firing).

Adds `globals: ^17.6.0` to root devDependencies. Removes
@react-native/eslint-config and @react-native/eslint-plugin from root
devDependencies.

Author: oliverlaz

eslint.config.mjs

@@ -1,36 +1,28 @@
 import jsEslint from '@eslint/js';
-import eslintReactNativeConfig from '@react-native/eslint-config';
-import eslintPluginReactNativeOfficial from '@react-native/eslint-plugin';
+import eslintConfigPrettier from 'eslint-config-prettier';
 import eslintPluginComments from 'eslint-plugin-eslint-comments';
 import eslintPluginImport from 'eslint-plugin-import';
 import eslintPluginJest from 'eslint-plugin-jest';
 import eslintPluginPrettier from 'eslint-plugin-prettier';
 import eslintPluginReact from 'eslint-plugin-react';
 import eslintPluginReactHooks from 'eslint-plugin-react-hooks';
 import eslintPluginReactNative from 'eslint-plugin-react-native';
-
+import globals from 'globals';
 import tsEslint from 'typescript-eslint';
-import eslintConfigPrettier from 'eslint-config-prettier';
 
-/**
- * @react-native/eslint-config stores globals as `true`/`false`. We rebuild the
- * map with `'readonly'` so flat config accepts them.
- */
-const reactNativeGlobals = Object.keys(eslintReactNativeConfig.globals ?? {}).reduce((acc, key) => {
-  if (eslintReactNativeConfig.globals[key]) {
-    acc[key] = 'readonly';
-  }
-  return acc;
-}, {});
-
-const reactNativeRules = Object.fromEntries(
-  Object.entries(eslintReactNativeConfig.rules ?? {}).filter(([key]) => !key.startsWith('jest/')),
-);
+// React Native runtime globals that aren't in the standard `globals` package presets.
+const reactNativeGlobals = {
+  __DEV__: 'readonly',
+};
 
 export default tsEslint.config(
   jsEslint.configs.recommended,
   tsEslint.configs.recommended,
   eslintPluginReact.configs.flat.recommended,
+  // Settings that apply to every config object below. Without this, eslint-plugin-react's
+  // recommended preset runs with no React version and logs "React version not specified"
+  // on every invocation -- `detect` fails because React isn't a direct root dep.
+  { settings: { react: { version: '19' } } },
   {
     ignores: [
       // Dependencies and build outputs
@@ -90,7 +82,12 @@ export default tsEslint.config(
     files: ['**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx'],
     languageOptions: {
       ecmaVersion: 2020,
-      globals: reactNativeGlobals,
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+        ...globals.es2021,
+        ...reactNativeGlobals,
+      },
       parser: tsEslint.parser,
       parserOptions: {
         ecmaFeatures: {
@@ -101,7 +98,6 @@ export default tsEslint.config(
       sourceType: 'module',
     },
     plugins: {
-      '@react-native': eslintPluginReactNativeOfficial,
       'eslint-comments': eslintPluginComments,
       import: eslintPluginImport,
       prettier: eslintPluginPrettier,
@@ -136,16 +132,30 @@ export default tsEslint.config(
       },
     },
     rules: {
-      ...reactNativeRules,
       ...eslintConfigPrettier.rules,
+
+      // -- Silencing recommended-preset rules that don't fit this codebase.
+      // These were previously masked by @react-native/eslint-config; we keep them off
+      // explicitly to preserve behavior now that the config is owned in-tree.
+      'no-constant-condition': 'off',
+      'no-empty': 'off',
+      'no-inner-declarations': 'off',
+      'no-redeclare': 'off',
       'no-undef': 'off',
+      'no-unused-vars': 'off',
+      'react/display-name': 'off',
+      'react/no-unknown-property': 'off',
+      'react/react-in-jsx-scope': 'off',
+      'react/prop-types': 'off',
+
+      // -- Project conventions.
       'prettier/prettier': 'warn',
       'arrow-body-style': 'off',
       'prefer-arrow-callback': 'off',
-      'array-callback-return': 2,
-      'comma-dangle': 0,
-      'default-case': 2,
-      eqeqeq: [2, 'smart'],
+      'array-callback-return': 'error',
+      'comma-dangle': 'off',
+      'default-case': 'error',
+      eqeqeq: ['error', 'smart'],
       // TypeScript already catches unresolved imports; the eslint-import-resolver-node
       // resolver doesn't understand Yarn workspace hoisting or TS path aliases, so we
       // turn this off repo-wide to avoid false positives in example apps.
@@ -170,23 +180,24 @@ export default tsEslint.config(
         },
       ],
       'jsx-quotes': ['error', 'prefer-single'],
-      'linebreak-style': [2, 'unix'],
-      'no-console': 0,
-      'no-mixed-spaces-and-tabs': 1,
-      'no-self-compare': 2,
-      'no-underscore-dangle': [2, { allowAfterThis: true }],
-      'no-unused-vars': 'off',
-      'no-useless-concat': 2,
-      'no-var': 2,
-      'object-shorthand': 1,
-      'prefer-const': 1,
-      'react/prop-types': 0,
-      'require-await': 2,
-      semi: [1, 'always'],
-      'valid-typeof': 2,
-      '@typescript-eslint/explicit-module-boundary-types': 0,
-      '@typescript-eslint/no-empty-interface': 0,
-      '@typescript-eslint/ban-ts-comment': 0,
+      'linebreak-style': ['error', 'unix'],
+      'no-console': 'off',
+      'no-mixed-spaces-and-tabs': 'warn',
+      'no-self-compare': 'error',
+      'no-shadow': 'off',
+      'no-underscore-dangle': ['error', { allowAfterThis: true }],
+      'no-useless-concat': 'error',
+      'no-var': 'error',
+      'object-shorthand': 'warn',
+      'prefer-const': 'warn',
+      'require-await': 'error',
+      semi: ['warn', 'always'],
+      'valid-typeof': 'error',
+
+      // -- TypeScript-specific.
+      '@typescript-eslint/explicit-module-boundary-types': 'off',
+      '@typescript-eslint/no-empty-interface': 'off',
+      '@typescript-eslint/ban-ts-comment': 'off',
       '@typescript-eslint/no-unused-vars': [
         'warn',
         {
@@ -197,13 +208,20 @@ export default tsEslint.config(
         },
       ],
       '@typescript-eslint/no-unused-expressions': 'off',
-      '@typescript-eslint/no-var-requires': 0,
+      '@typescript-eslint/no-var-requires': 'off',
       '@typescript-eslint/no-require-imports': 'off',
-      'react-hooks/exhaustive-deps': 1,
-      'react-native/no-inline-styles': 0,
-      'babel/no-invalid-this': 0,
       '@typescript-eslint/no-invalid-this': 'error',
-      'no-shadow': 0,
+
+      // -- React / React Native.
+      'react-hooks/exhaustive-deps': 'warn',
+      'react-hooks/rules-of-hooks': 'error',
+      'react-native/no-inline-styles': 'off',
+      'react/no-unstable-nested-components': 'warn',
+
+      // -- Hygiene rules previously enabled via @react-native/eslint-config that we
+      // kept after dropping the package -- they catch real footguns.
+      'no-bitwise': 'warn',
+      'no-extend-native': 'warn',
     },
   },
   {
@@ -221,10 +239,8 @@ export default tsEslint.config(
       'jest/expect-expect': 'off',
       'jest/no-conditional-expect': 'off',
       'jest/prefer-inline-snapshots': 'off',
-      'jest/lowercase-name': 'off',
       'jest/prefer-expect-assertions': 'off',
       'jest/no-hooks': 'off',
-      'jest/no-if': 'off',
       'jest/prefer-spy-on': 'off',
     },
   },

examples/ExpoMessaging/package.json

@@ -24,7 +24,7 @@
     "@react-navigation/elements": "^2.9.10",
     "@react-navigation/native": "^7.1.33",
     "@react-navigation/native-stack": "^7.14.5",
-    "@shopify/flash-list": "2.0.2",
+    "@shopify/flash-list": "^2.3.1",
     "expo": "^55.0.6",
     "expo-audio": "~55.0.8",
     "expo-build-properties": "~55.0.9",

examples/SampleApp/package.json

@@ -44,7 +44,7 @@
     "@react-navigation/drawer": "7.4.1",
     "@react-navigation/native": "^7.1.19",
     "@react-navigation/native-stack": "^7.6.2",
-    "@shopify/flash-list": "^2.1.0",
+    "@shopify/flash-list": "^2.3.1",
     "emoji-mart": "^5.6.0",
     "lodash.mergewith": "^4.6.2",
     "react": "19.1.4",

package.json

@@ -37,8 +37,6 @@
     "@commitlint/cli": "^21.0.0",
     "@commitlint/config-conventional": "^21.0.0",
     "@eslint/js": "^9.39.4",
-    "@react-native/eslint-config": "^0.81.6",
-    "@react-native/eslint-plugin": "^0.81.6",
     "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/exec": "^6.0.3",
     "@semantic-release/git": "^10.0.1",
@@ -54,6 +52,7 @@
     "eslint-plugin-react-hooks": "^7.1.1",
     "eslint-plugin-react-native": "^5.0.0",
     "execa": "^5.1.1",
+    "globals": "^17.6.0",
     "husky": "^9.1.7",
     "prettier": "^3.8.3",
     "semantic-release": "^25.0.3",

package/package.json

@@ -119,7 +119,7 @@
     "@op-engineering/op-sqlite": "^14.0.3",
     "@react-native-community/netinfo": "^11.4.1",
     "@react-native/babel-preset": "0.79.3",
-    "@shopify/flash-list": "^2.1.0",
+    "@shopify/flash-list": "^2.3.1",
     "@testing-library/jest-native": "^5.4.3",
     "@testing-library/react-native": "13.2.0",
     "@total-typescript/shoehorn": "^0.1.2",