Commit 5f72b09
authored
fix: message gallery overflow styles (#3615)
## 🎯 Goal
This PR addresses an unfortunate regression introduced in [this
PR](#3600). We
need the `overflow: 'hidden'` after all, for single image messages.
Regardless, everything mentioned in the previous PR still holds true; we
just force the rendering into a bounding rectangle once again by
applying `borderWidth` (which even if `0`, still forces the shape as it
exists).
## 🛠 Implementation details
<!-- Provide a description of the implementation -->
## 🎨 UI Changes
<!-- Add relevant screenshots -->
<details>
<summary>iOS</summary>
<table>
<thead>
<tr>
<td>Before</td>
<td>After</td>
</tr>
</thead>
<tbody>
<tr>
<td>
<!--<img src="" /> -->
</td>
<td>
<!--<img src="" /> -->
</td>
</tr>
</tbody>
</table>
</details>
<details>
<summary>Android</summary>
<table>
<thead>
<tr>
<td>Before</td>
<td>After</td>
</tr>
</thead>
<tbody>
<tr>
<td>
<!--<img src="" /> -->
</td>
<td>
<!--<img src="" /> -->
</td>
</tr>
</tbody>
</table>
</details>
## 🧪 Testing
<!-- Explain how this change can be tested (or why it can't be tested)
-->
## ☑️ Checklist
- [ ] I have signed the [Stream
CLA](https://docs.google.com/forms/d/e/1FAIpQLScFKsKkAJI7mhCr7K9rEIOpqIDThrWxuvxnwUq2XkHyG154vQ/viewform)
(required)
- [ ] PR targets the `develop` branch
- [ ] Documentation is updated
- [ ] New code is tested in main example apps, including all possible
scenarios
- [ ] SampleApp iOS and Android
- [ ] Expo iOS and Android1 parent c286c5b commit 5f72b09
2 files changed
Lines changed: 10 additions & 0 deletions
File tree
- package/src/components
- Message/MessageItemView
- Thread/__tests__/__snapshots__
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
656 | 656 | | |
657 | 657 | | |
658 | 658 | | |
| 659 | + | |
| 660 | + | |
659 | 661 | | |
660 | 662 | | |
661 | 663 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
506 | 506 | | |
507 | 507 | | |
508 | 508 | | |
| 509 | + | |
| 510 | + | |
509 | 511 | | |
510 | 512 | | |
511 | 513 | | |
| |||
848 | 850 | | |
849 | 851 | | |
850 | 852 | | |
| 853 | + | |
| 854 | + | |
851 | 855 | | |
852 | 856 | | |
853 | 857 | | |
| |||
1223 | 1227 | | |
1224 | 1228 | | |
1225 | 1229 | | |
| 1230 | + | |
| 1231 | + | |
1226 | 1232 | | |
1227 | 1233 | | |
1228 | 1234 | | |
| |||
1556 | 1562 | | |
1557 | 1563 | | |
1558 | 1564 | | |
| 1565 | + | |
| 1566 | + | |
1559 | 1567 | | |
1560 | 1568 | | |
1561 | 1569 | | |
| |||
0 commit comments