Commit 7642d24
committed
refactor: replace Record<string, unknown> with specific types
Cuts `Record<string, unknown>` uses from 57 → 22. The remaining 22 are
legitimate: generic parameter defaults on public API types
(`CustomLocalMetadata`), the `UnknownType` export, `Message.additionalInfo`
(genuine bag-of-data prop), `useStateStore` / `usePollStateStore` generic
constraints, `topologicalResolution` plain-object type guards,
`BetterSqlite.selectFromTable` default row type, the i18n formatter
`options` (matches i18next API shape), and the one remaining
`exception_fields` field on `mock-builders/api/error.ts` which matches
the real Stream API error shape.
**Source / mock-builders:**
- mock-builders/api/initiateClientWithChannels.ts: alias
`ChannelData` as `Parameters<typeof generateChannel>[0]`.
- mock-builders/generator/channel.ts: drop unused `_client` field (only
ever set to `{}`, no consumers).
- mock-builders/attachments.ts: narrow override arg to
`Partial<LocalAttachmentData & { file: Partial<FileReference> }>`
(both callers pass no overrides anyway).
- mock-builders/mock.ts: replace two `as unknown as Record<string,
unknown>` + `as never` casts with a single `type WithPrivates` cast
for `_setToken` / `_setupConnection` spies.
- components/UIComponents/SwipableWrapper.tsx: `Content` prop typed as
bare `React.ComponentType` (rendered as `<Content />` with no props).
**Tests:**
- Channel.test.tsx: 9 uses replaced — `RenderComponentProps` becomes
`Partial<ComponentProps<typeof Channel>>` (with `channel?: unknown` to
allow the one test that passes an ad-hoc shape); context-cast sites
use `typeof mockContext` so test mocks can mix fields from
`ChatContextValue` + `MessagesContextValue`; `T extends object`
generic; `typeof channel.state.messages`; `Partial<ReturnType<typeof
MessageListPaginationHooks.useMessageListPagination>>`; `typeof
channel.state.read`.
- Giphy.test.tsx: 10 uses replaced with `ComponentProps<typeof Image>`
+ `StyleProp<ImageStyle>` / `ImageStyle` from `react-native`.
- ChannelList.test.tsx: `filters` arg typed as
`Parameters<typeof chatClient.queryChannels>[0]`.
- MessageContent.test.tsx: override-component prop types switched to
`MessageHeaderProps` / `MessageFooterProps` from the component
sources.
- useMessageListPagination.test.tsx: `mockedHook` args typed as
`Partial<typeof channelInitialState>` and `Partial<ReturnType<
typeof ChannelStateHooks.useChannelMessageDataState>>`.
- ChannelDetailsBottomSheet.test.tsx: 3 uses replaced with
`ComponentProps<typeof StreamBottomSheetModalFlatList>`.
- ChannelSwipableWrapper.test.tsx: `ComponentProps<typeof
SwipableWrapper>`.
- ChannelPreview.test.tsx: override-map types from
`Parameters<typeof generateChannelResponse>[0]` and `Partial<Channel>`.
test:typecheck: 0 errors. Full test suite: same pre-existing
SQLite-isolation flake; no regressions.1 parent e43ed04 commit 7642d24
13 files changed
Lines changed: 56 additions & 57 deletions
File tree
- package/src
- components
- Attachment/__tests__
- ChannelList/__tests__
- ChannelPreview/__tests__
- Channel/__tests__
- Message/MessageItemView/__tests__
- UIComponents
- mock-builders
- api
- generator
Lines changed: 9 additions & 20 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
196 | 197 | | |
197 | 198 | | |
198 | 199 | | |
199 | | - | |
| 200 | + | |
200 | 201 | | |
201 | 202 | | |
202 | | - | |
203 | | - | |
204 | | - | |
| 203 | + | |
205 | 204 | | |
206 | 205 | | |
207 | 206 | | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
| 207 | + | |
| 208 | + | |
214 | 209 | | |
215 | 210 | | |
216 | 211 | | |
| |||
221 | 216 | | |
222 | 217 | | |
223 | 218 | | |
224 | | - | |
| 219 | + | |
225 | 220 | | |
226 | 221 | | |
227 | | - | |
228 | | - | |
229 | | - | |
| 222 | + | |
230 | 223 | | |
231 | 224 | | |
232 | 225 | | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
| 226 | + | |
| 227 | + | |
239 | 228 | | |
240 | 229 | | |
241 | 230 | | |
| |||
Lines changed: 16 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
77 | 80 | | |
78 | 81 | | |
79 | 82 | | |
| |||
282 | 285 | | |
283 | 286 | | |
284 | 287 | | |
285 | | - | |
| 288 | + | |
286 | 289 | | |
287 | 290 | | |
288 | 291 | | |
| |||
325 | 328 | | |
326 | 329 | | |
327 | 330 | | |
328 | | - | |
| 331 | + | |
329 | 332 | | |
330 | 333 | | |
331 | 334 | | |
| |||
461 | 464 | | |
462 | 465 | | |
463 | 466 | | |
464 | | - | |
465 | | - | |
466 | | - | |
467 | | - | |
468 | | - | |
| 467 | + | |
469 | 468 | | |
470 | 469 | | |
471 | 470 | | |
| |||
490 | 489 | | |
491 | 490 | | |
492 | 491 | | |
493 | | - | |
| 492 | + | |
494 | 493 | | |
495 | 494 | | |
496 | 495 | | |
| |||
532 | 531 | | |
533 | 532 | | |
534 | 533 | | |
535 | | - | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
536 | 537 | | |
537 | 538 | | |
538 | 539 | | |
| |||
556 | 557 | | |
557 | 558 | | |
558 | 559 | | |
559 | | - | |
| 560 | + | |
560 | 561 | | |
561 | 562 | | |
562 | 563 | | |
563 | 564 | | |
564 | | - | |
| 565 | + | |
565 | 566 | | |
566 | 567 | | |
567 | 568 | | |
| |||
591 | 592 | | |
592 | 593 | | |
593 | 594 | | |
594 | | - | |
| 595 | + | |
595 | 596 | | |
596 | 597 | | |
597 | 598 | | |
| |||
626 | 627 | | |
627 | 628 | | |
628 | 629 | | |
629 | | - | |
| 630 | + | |
630 | 631 | | |
631 | 632 | | |
632 | 633 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
218 | | - | |
| 218 | + | |
219 | 219 | | |
220 | 220 | | |
221 | 221 | | |
| |||
Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| 14 | + | |
| 15 | + | |
13 | 16 | | |
14 | 17 | | |
15 | | - | |
| 18 | + | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
19 | | - | |
| 22 | + | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
| |||
77 | 80 | | |
78 | 81 | | |
79 | 82 | | |
80 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
81 | 86 | | |
82 | 87 | | |
83 | 88 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
| 108 | + | |
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
| |||
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
63 | | - | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
26 | 28 | | |
27 | 29 | | |
28 | 30 | | |
| |||
117 | 119 | | |
118 | 120 | | |
119 | 121 | | |
120 | | - | |
| 122 | + | |
121 | 123 | | |
122 | 124 | | |
123 | 125 | | |
| |||
143 | 145 | | |
144 | 146 | | |
145 | 147 | | |
146 | | - | |
| 148 | + | |
147 | 149 | | |
148 | 150 | | |
149 | 151 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
0 commit comments