Skip to content

Commit 95e137f

Browse files
committed
ci: wire yarn test:typecheck into PR checks
Adds a `Typecheck tests` step to check-pr.yml that runs `yarn test:typecheck` (tsc --noEmit -p tsconfig.test.json) in the package/ workspace between lint and test. Tests and mock-builders are now type-gated at PR time. Leaves `noImplicitAny: false` in tsconfig.test.json with a TODO comment. Flipping it exposes ~630 mechanical implicit-any errors (destructured-parameter and `let`-variable annotations across ~60 test files). Filing as separate follow-up rather than ballooning this PR further. Full error count at this commit: 0.
1 parent 0d164b6 commit 95e137f

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

.github/workflows/check-pr.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,7 @@ jobs:
2929
uses: ./.github/actions/install-and-build-sdk
3030
- name: Lint
3131
run: yarn lerna-workspaces run lint
32+
- name: Typecheck tests
33+
run: cd package && yarn test:typecheck
3234
- name: Test
3335
run: yarn test:coverage

package/tsconfig.test.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
"compilerOptions": {
44
"noUnusedLocals": false,
55
"noUnusedParameters": false,
6+
// TODO: flip to `true` after annotating the ~630 remaining implicit-any
7+
// errors in test files (mostly destructured-parameter and `let`-variable
8+
// annotations). See follow-up issue.
69
"noImplicitAny": false
710
},
811
"include": ["./src/**/*"],

0 commit comments

Comments
 (0)