chore: rename multisend prop for audio and default it to true

Author: isekovanic

package/src/components/Channel/Channel.tsx

@@ -576,8 +576,8 @@ const ChannelWithContext = (props: PropsWithChildren<ChannelPropsWithContext>) =
     allowThreadMessagesInChannel = true,
     asyncMessagesLockDistance = 50,
     asyncMessagesMinimumPressDuration = 500,
-    asyncMessagesMultiSendEnabled = true,
     asyncMessagesSlideToCancelDistance = 75,
+    audioRecordingSendOnComplete = true,
     AttachButton = AttachButtonDefault,
     Attachment = AttachmentDefault,
     attachmentPickerBottomSheetHeight = disableAttachmentPicker ? 72 : 333,
@@ -1852,7 +1852,7 @@ const ChannelWithContext = (props: PropsWithChildren<ChannelPropsWithContext>) =
     allowSendBeforeAttachmentsUpload,
     asyncMessagesLockDistance,
     asyncMessagesMinimumPressDuration,
-    asyncMessagesMultiSendEnabled,
+    audioRecordingSendOnComplete,
     asyncMessagesSlideToCancelDistance,
     AttachButton,
     attachmentPickerBottomSheetHeight,

package/src/components/Channel/hooks/useCreateInputMessageInputContext.ts

@@ -7,8 +7,8 @@ export const useCreateInputMessageInputContext = ({
   allowSendBeforeAttachmentsUpload,
   asyncMessagesLockDistance,
   asyncMessagesMinimumPressDuration,
-  asyncMessagesMultiSendEnabled,
   asyncMessagesSlideToCancelDistance,
+  audioRecordingSendOnComplete,
   AttachButton,
   attachmentPickerBottomSheetHeight,
   AttachmentPickerSelectionBar,
@@ -77,8 +77,8 @@ export const useCreateInputMessageInputContext = ({
       allowSendBeforeAttachmentsUpload,
       asyncMessagesLockDistance,
       asyncMessagesMinimumPressDuration,
-      asyncMessagesMultiSendEnabled,
       asyncMessagesSlideToCancelDistance,
+      audioRecordingSendOnComplete,
       AttachButton,
       attachmentPickerBottomSheetHeight,
       AttachmentPickerSelectionBar,

package/src/components/MessageInput/MessageComposer.tsx

@@ -155,11 +155,11 @@ type MessageComposerPropsWithContext = Pick<ChatContextValue, 'isOnline'> &
     MessageInputContextValue,
     | 'audioRecorderManager'
     | 'additionalTextInputProps'
+    | 'audioRecordingSendOnComplete'
     | 'audioRecordingEnabled'
     | 'asyncMessagesLockDistance'
     | 'asyncMessagesMinimumPressDuration'
     | 'asyncMessagesSlideToCancelDistance'
-    | 'asyncMessagesMultiSendEnabled'
     | 'AttachmentUploadPreviewList'
     | 'AudioRecorder'
     | 'AudioRecordingInProgress'
@@ -515,6 +515,7 @@ const areEqual = (
     asyncMessagesLockDistance: prevAsyncMessagesLockDistance,
     asyncMessagesMinimumPressDuration: prevAsyncMessagesMinimumPressDuration,
     asyncMessagesSlideToCancelDistance: prevAsyncMessagesSlideToCancelDistance,
+    audioRecordingSendOnComplete: prevAudioRecordingSendOnComplete,
     audioRecordingEnabled: prevAsyncMessagesEnabled,
     channel: prevChannel,
     closePollCreationDialog: prevClosePollCreationDialog,
@@ -534,6 +535,7 @@ const areEqual = (
     asyncMessagesLockDistance: nextAsyncMessagesLockDistance,
     asyncMessagesMinimumPressDuration: nextAsyncMessagesMinimumPressDuration,
     asyncMessagesSlideToCancelDistance: nextAsyncMessagesSlideToCancelDistance,
+    audioRecordingSendOnComplete: nextAudioRecordingSendOnComplete,
     audioRecordingEnabled: nextAsyncMessagesEnabled,
     channel: nextChannel,
     closePollCreationDialog: nextClosePollCreationDialog,
@@ -597,6 +599,12 @@ const areEqual = (
     return false;
   }
 
+  const audioRecordingSendOnCompleteEqual =
+    prevAudioRecordingSendOnComplete === nextAudioRecordingSendOnComplete;
+  if (!audioRecordingSendOnCompleteEqual) {
+    return false;
+  }
+
   const editingEqual = !!prevEditing === !!nextEditing;
   if (!editingEqual) {
     return false;
@@ -655,9 +663,9 @@ export const MessageComposer = (props: MessageComposerProps) => {
   const {
     audioRecorderManager,
     additionalTextInputProps,
+    audioRecordingSendOnComplete,
     asyncMessagesLockDistance,
     asyncMessagesMinimumPressDuration,
-    asyncMessagesMultiSendEnabled,
     asyncMessagesSlideToCancelDistance,
     AttachmentUploadPreviewList,
     AudioRecorder,
@@ -720,9 +728,9 @@ export const MessageComposer = (props: MessageComposerProps) => {
         recordingStatus,
         micLocked,
         additionalTextInputProps,
+        audioRecordingSendOnComplete,
         asyncMessagesLockDistance,
         asyncMessagesMinimumPressDuration,
-        asyncMessagesMultiSendEnabled,
         asyncMessagesSlideToCancelDistance,
         AttachmentUploadPreviewList,
         AudioRecorder,

package/src/components/MessageInput/components/AudioRecorder/AudioRecorder.tsx

@@ -27,7 +27,7 @@ import { primitives } from '../../../../theme';
 type AudioRecorderPropsWithContext = Pick<
   MessageInputContextValue,
   | 'audioRecorderManager'
-  | 'asyncMessagesMultiSendEnabled'
+  | 'audioRecordingSendOnComplete'
   | 'stopVoiceRecording'
   | 'deleteVoiceRecording'
   | 'uploadVoiceRecording'
@@ -70,15 +70,15 @@ const StopRecording = ({
 };
 
 const UploadRecording = ({
-  asyncMessagesMultiSendEnabled,
+  audioRecordingSendOnComplete,
   uploadVoiceRecordingHandler,
 }: {
-  asyncMessagesMultiSendEnabled: boolean;
-  uploadVoiceRecordingHandler: (multiSendEnabled: boolean) => Promise<void>;
+  audioRecordingSendOnComplete: boolean;
+  uploadVoiceRecordingHandler: (sendOnComplete: boolean) => Promise<void>;
 }) => {
   const onUploadVoiceRecording = () => {
     NativeHandlers.triggerHaptic('impactMedium');
-    uploadVoiceRecordingHandler(asyncMessagesMultiSendEnabled);
+    uploadVoiceRecordingHandler(audioRecordingSendOnComplete);
   };
 
   return (
@@ -116,7 +116,7 @@ const DeleteRecording = ({
 
 const AudioRecorderWithContext = (props: AudioRecorderPropsWithContext) => {
   const {
-    asyncMessagesMultiSendEnabled,
+    audioRecordingSendOnComplete,
     slideToCancelStyle,
     deleteVoiceRecording,
     stopVoiceRecording,
@@ -144,7 +144,7 @@ const AudioRecorderWithContext = (props: AudioRecorderPropsWithContext) => {
         <View style={styles.container}>
           <DeleteRecording deleteVoiceRecordingHandler={deleteVoiceRecording} />
           <UploadRecording
-            asyncMessagesMultiSendEnabled={asyncMessagesMultiSendEnabled}
+            audioRecordingSendOnComplete={audioRecordingSendOnComplete}
             uploadVoiceRecordingHandler={uploadVoiceRecording}
           />
         </View>
@@ -155,7 +155,7 @@ const AudioRecorderWithContext = (props: AudioRecorderPropsWithContext) => {
           <DeleteRecording deleteVoiceRecordingHandler={deleteVoiceRecording} />
           <StopRecording stopVoiceRecordingHandler={stopVoiceRecording} />
           <UploadRecording
-            asyncMessagesMultiSendEnabled={asyncMessagesMultiSendEnabled}
+            audioRecordingSendOnComplete={audioRecordingSendOnComplete}
             uploadVoiceRecordingHandler={uploadVoiceRecording}
           />
         </View>
@@ -201,7 +201,7 @@ const audioRecorderSelector = (state: AudioRecorderManagerState) => ({
 export const AudioRecorder = (props: AudioRecorderProps) => {
   const {
     audioRecorderManager,
-    asyncMessagesMultiSendEnabled,
+    audioRecordingSendOnComplete,
     stopVoiceRecording,
     deleteVoiceRecording,
     uploadVoiceRecording,
@@ -216,7 +216,7 @@ export const AudioRecorder = (props: AudioRecorderProps) => {
     <MemoizedAudioRecorder
       {...{
         audioRecorderManager,
-        asyncMessagesMultiSendEnabled,
+        audioRecordingSendOnComplete,
         stopVoiceRecording,
         deleteVoiceRecording,
         uploadVoiceRecording,

package/src/components/MessageInput/components/AudioRecorder/AudioRecordingButton.tsx

@@ -31,7 +31,7 @@ export type AudioRecordingButtonPropsWithContext = Pick<
   | 'asyncMessagesMinimumPressDuration'
   | 'asyncMessagesSlideToCancelDistance'
   | 'asyncMessagesLockDistance'
-  | 'asyncMessagesMultiSendEnabled'
+  | 'audioRecordingSendOnComplete'
   | 'audioRecorderManager'
   | 'startVoiceRecording'
   | 'deleteVoiceRecording'
@@ -67,7 +67,7 @@ export const AudioRecordingButtonWithContext = (props: AudioRecordingButtonProps
     asyncMessagesMinimumPressDuration,
     asyncMessagesSlideToCancelDistance,
     asyncMessagesLockDistance,
-    asyncMessagesMultiSendEnabled,
+    audioRecordingSendOnComplete,
     startVoiceRecording,
     deleteVoiceRecording,
     uploadVoiceRecording,
@@ -156,7 +156,7 @@ export const AudioRecordingButtonWithContext = (props: AudioRecordingButtonProps
       return;
     }
     if (status === 'recording') {
-      uploadVoiceRecording(asyncMessagesMultiSendEnabled);
+      uploadVoiceRecording(audioRecordingSendOnComplete);
     } else {
       resetAudioRecording();
     }
@@ -263,7 +263,7 @@ export const AudioRecordingButton = (props: AudioRecordingButtonProps) => {
     asyncMessagesMinimumPressDuration,
     asyncMessagesSlideToCancelDistance,
     asyncMessagesLockDistance,
-    asyncMessagesMultiSendEnabled,
+    audioRecordingSendOnComplete,
     startVoiceRecording,
     deleteVoiceRecording,
     uploadVoiceRecording,
@@ -281,7 +281,7 @@ export const AudioRecordingButton = (props: AudioRecordingButtonProps) => {
         asyncMessagesMinimumPressDuration,
         asyncMessagesSlideToCancelDistance,
         asyncMessagesLockDistance,
-        asyncMessagesMultiSendEnabled,
+        audioRecordingSendOnComplete,
         startVoiceRecording,
         deleteVoiceRecording,
         uploadVoiceRecording,

package/src/components/MessageInput/components/OutputButtons/index.tsx

@@ -33,7 +33,7 @@ export type OutputButtonsWithContextProps = Pick<ChatContextValue, 'isOnline'> &
     | 'asyncMessagesMinimumPressDuration'
     | 'asyncMessagesSlideToCancelDistance'
     | 'asyncMessagesLockDistance'
-    | 'asyncMessagesMultiSendEnabled'
+    | 'audioRecordingSendOnComplete'
     | 'audioRecordingEnabled'
     | 'CooldownTimer'
     | 'SendButton'
@@ -178,7 +178,7 @@ export const OutputButtons = (props: OutputButtonsProps) => {
     asyncMessagesMinimumPressDuration,
     asyncMessagesSlideToCancelDistance,
     asyncMessagesLockDistance,
-    asyncMessagesMultiSendEnabled,
+    audioRecordingSendOnComplete,
     CooldownTimer,
     SendButton,
     StopMessageStreamingButton,
@@ -192,7 +192,7 @@ export const OutputButtons = (props: OutputButtonsProps) => {
       {...{
         asyncMessagesLockDistance,
         asyncMessagesMinimumPressDuration,
-        asyncMessagesMultiSendEnabled,
+        audioRecordingSendOnComplete,
         asyncMessagesSlideToCancelDistance,
         audioRecordingEnabled,
         channel,

package/src/components/MessageInput/hooks/useAudioRecorder.tsx

@@ -68,10 +68,10 @@ export const useAudioRecorder = ({
 
   /**
    * Function to upload or send voice recording.
-   * @param multiSendEnabled boolean
+   * @param sendOnComplete boolean
    */
   const uploadVoiceRecording = useCallback(
-    async (multiSendEnabled: boolean) => {
+    async (sendOnComplete: boolean) => {
       try {
         const { recording, duration, waveformData } = audioRecorderManager.state.getLatestValue();
         await stopVoiceRecording();
@@ -112,12 +112,11 @@ export const useAudioRecorder = ({
 
         audioRecorderManager.reset();
 
-        if (multiSendEnabled) {
+        if (sendOnComplete) {
           await attachmentManager.uploadAttachment(audioFile);
+          setIsScheduleForSubmit(true);
         } else {
-          // FIXME: cannot call handleSubmit() directly as the function has stale reference to file uploads
           await attachmentManager.uploadAttachment(audioFile);
-          setIsScheduleForSubmit(true);
         }
       } catch (error) {
         console.log('Error uploading voice recording: ', error);

package/src/contexts/messageInputContext/MessageInputContext.tsx

@@ -98,7 +98,7 @@ export type LocalMessageInputContext = {
   audioRecorderManager: AudioRecorderManager;
   startVoiceRecording: () => Promise<boolean | undefined>;
   deleteVoiceRecording: () => Promise<void>;
-  uploadVoiceRecording: (multiSendEnabled: boolean) => Promise<void>;
+  uploadVoiceRecording: (sendOnComplete: boolean) => Promise<void>;
   stopVoiceRecording: () => Promise<void>;
 };
 
@@ -114,10 +114,11 @@ export type InputMessageInputContextValue = {
    */
   asyncMessagesMinimumPressDuration: number;
   /**
-   * When it’s enabled, recorded messages won’t be sent immediately. Instead they will “stack up” in the composer
-   * allowing the user to send multiple voice recording as part of the same message.
+   * Controls whether a completed voice recording is sent immediately or added to the composer first.
+   * When true, the recording is sent immediately on completion.
+   * When false, the recording is added to the composer and only sent if the user decides to.
    */
-  asyncMessagesMultiSendEnabled: boolean;
+  audioRecordingSendOnComplete: boolean;
   /**
    * Controls how many pixels to the leading side the user has to scroll in order to cancel the recording of a voice
    * message.

package/src/contexts/messageInputContext/hooks/useCreateMessageInputContext.ts

@@ -7,8 +7,8 @@ export const useCreateMessageInputContext = ({
   additionalTextInputProps,
   asyncMessagesLockDistance,
   asyncMessagesMinimumPressDuration,
-  asyncMessagesMultiSendEnabled,
   asyncMessagesSlideToCancelDistance,
+  audioRecordingSendOnComplete,
   AttachButton,
   attachmentPickerBottomSheetHeight,
   AttachmentPickerSelectionBar,
@@ -86,8 +86,8 @@ export const useCreateMessageInputContext = ({
       additionalTextInputProps,
       asyncMessagesLockDistance,
       asyncMessagesMinimumPressDuration,
-      asyncMessagesMultiSendEnabled,
       asyncMessagesSlideToCancelDistance,
+      audioRecordingSendOnComplete,
       AttachButton,
       attachmentPickerBottomSheetHeight,
       AttachmentPickerSelectionBar,