Skip to content

Commit ebbb3fa

Browse files
authored
fix: autocomplete suggestions list styles (#3601)
## 🎯 Goal Resolves [this GH issue](#3438) and potentially [this one](#3433) as well. For [3433](#3433), while I cannot reproduce the issue at all the safeguard should help in case there are some weird device/customization/RN version combinations. The only way I could actually reproduce it was with a fixed `height`, against which we can of course not guard and is up to the integration to fix downstream. ## 🛠 Implementation details <!-- Provide a description of the implementation --> ## 🎨 UI Changes <!-- Add relevant screenshots --> <details> <summary>iOS</summary> <table> <thead> <tr> <td>Before</td> <td>After</td> </tr> </thead> <tbody> <tr> <td> <!--<img src="" /> --> </td> <td> <!--<img src="" /> --> </td> </tr> </tbody> </table> </details> <details> <summary>Android</summary> <table> <thead> <tr> <td>Before</td> <td>After</td> </tr> </thead> <tbody> <tr> <td> <!--<img src="" /> --> </td> <td> <!--<img src="" /> --> </td> </tr> </tbody> </table> </details> ## 🧪 Testing <!-- Explain how this change can be tested (or why it can't be tested) --> ## ☑️ Checklist - [ ] I have signed the [Stream CLA](https://docs.google.com/forms/d/e/1FAIpQLScFKsKkAJI7mhCr7K9rEIOpqIDThrWxuvxnwUq2XkHyG154vQ/viewform) (required) - [ ] PR targets the `develop` branch - [ ] Documentation is updated - [ ] New code is tested in main example apps, including all possible scenarios - [ ] SampleApp iOS and Android - [ ] Expo iOS and Android
1 parent 188ff5f commit ebbb3fa

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

package/src/components/AutoCompleteInput/AutoCompleteSuggestionList.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ export const AutoCompleteSuggestionList = ({
101101
renderItem={renderItem}
102102
style={[
103103
styles.flatlist,
104-
flatlist,
105104
{ backgroundColor: white, maxHeight, shadowColor: black },
105+
flatlist,
106106
]}
107107
testID={'auto-complete-suggestion-list'}
108108
/>
@@ -117,6 +117,7 @@ const styles = StyleSheet.create({
117117
flatlist: {
118118
borderRadius: 8,
119119
elevation: 3,
120+
flexGrow: 0,
120121
marginHorizontal: 8,
121122
shadowOffset: {
122123
height: 1,

0 commit comments

Comments
 (0)