feat: add support for react compiler bundled native handlers#3024
Merged
isekovanic merged 1 commit intodevelopfrom Mar 17, 2025
Merged
feat: add support for react compiler bundled native handlers#3024isekovanic merged 1 commit intodevelopfrom
isekovanic merged 1 commit intodevelopfrom
Conversation
Contributor
SDK Size
|
isekovanic
commented
Mar 14, 2025
| export const isFileSystemAvailable = () => !!saveFile || !!deleteFile; | ||
| export const isAudioRecorderAvailable = () => !!Audio?.startRecording; | ||
| export const isSoundPackageAvailable = () => !!Sound.Player || !!Sound.initializeSound; | ||
| export const isImagePickerAvailable = () => !!NativeHandlers.takePhoto; |
Contributor
Author
There was a problem hiding this comment.
These helpers can be directly imported, as they're using the referenced NativeHandlers object directly (and their return value will mutate with it)
khushal87
approved these changes
Mar 17, 2025
Contributor
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Starting from RN
0.77.0, some changes have been done to how the betaReact Compilerfeature resolves modules, specifically mutable exported variables.Since most of our actual native handlers were exactly that, practically none of them were functioning (seeing weird stuff like no
MessageListonstream-chat-expoapplications running this, or getting errors when trying to upload images or other attachments).This PR makes sure that the compiler does not try to optimize away used code and stores all of our
NativeHandlersin a mutable object which is then later consumed. This way,registerNativeHandlerscan properly mutate the object while the reference towards it stays the same and the compiler doesn't ignore it.🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch