Skip to content

fix: channel list stale last message #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isekovanic merged 1 commit into from
Apr 6, 2026
+2 −2
Merged

fix: channel list stale last message #3534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package/src/components/ChannelPreview/hooks/useChannelPreviewData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const useChannelPreviewData = (
) => {
const [forceUpdate, setForceUpdate] = useState(0);
const [lastMessage, setLastMessageInner] = useState<LastMessageType>(
() => channel.state.messages[channel.state.messages.length - 1],
() => channel.state.latestMessages[channel.state.latestMessages.length - 1],
Copy link
Copy Markdown
Contributor Author

@isekovanic isekovanic Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been wrong for years it seems, as we found with @MartinCupela . It's a pretty nasty edge case where if your first load of a channel is to a message in a different message set than the latest one (i.e through a deeplink let's say), the channel list would basically show the last message of that page only (and not the actual latest message in the channel).

);
const throttledSetLastMessage = useMemo(
() =>
Expand All @@ -44,7 +44,7 @@ export const useChannelPreviewData = (
const { forceUpdate: contextForceUpdate } = useChannelsContext();
const channelListForceUpdate = forceUpdateOverride ?? contextForceUpdate;

const channelLastMessage = channel.lastMessage();
const channelLastMessage = channel.state.latestMessages[channel.state.latestMessages.length - 1];
const channelLastMessageString = `${channelLastMessage?.id}${channelLastMessage?.updated_at}`;

const refreshUnreadCount = useMemo(
Expand Down
Loading