Post-review adjustments

Author: arnautov-anton

src/components/Avatar/Avatar.tsx

@@ -53,6 +53,7 @@ export const Avatar = ({
   className,
   FallbackIcon = IconUser,
   imageUrl,
+  initials: customInitials,
   isOnline,
   size,
   userName,
@@ -63,17 +64,16 @@ export const Avatar = ({
   useEffect(() => () => setError(false), [imageUrl]);
 
   const nameString = userName?.toString().trim() || '';
-  const avatarImageAlt = nameString.trim();
 
   const sizeAwareInitials = useMemo(() => {
-    const initials = rest.initials || getInitials(nameString);
+    const initials = customInitials || getInitials(nameString);
 
     if (size === 'sm' || size === 'xs') {
       return initials.charAt(0);
     }
 
     return initials;
-  }, [nameString, size, rest.initials]);
+  }, [nameString, size, customInitials]);
 
   const showImage = typeof imageUrl === 'string' && imageUrl && !error;
 
@@ -100,7 +100,7 @@ export const Avatar = ({
       )}
       {showImage ? (
         <img
-          alt={avatarImageAlt}
+          alt={nameString}
           className='str-chat__avatar-image'
           data-testid='avatar-img'
           onError={() => setError(true)}

src/components/TextareaComposer/SuggestionList/MentionItem/UserItem.tsx

@@ -32,16 +32,15 @@ export const UserItem = ({ entity, focused, ...buttonProps }: UserItemProps) =>
   const hasEntity = !!Object.keys(entity).length;
 
   const titleAttribute = entity.name || entity.id || '';
-  const displayInfo = extractDisplayInfo({ user: entity });
-  const LeadingSlot = useMemo(
-    () =>
-      function UserItemAvatar() {
-        // Decorative: the option's accessible name already carries the user's name (title +
-        // tokenized display name), so the avatar's fallback initials/role would only add noise.
-        return <Avatar {...displayInfo} aria-hidden size='md' />;
-      },
-    [Avatar, displayInfo],
-  );
+  const LeadingSlot = useMemo(() => {
+    const displayInfo = extractDisplayInfo({ user: entity });
+
+    return function UserItemAvatar() {
+      // Decorative: the option's accessible name already carries the user's name (title +
+      // tokenized display name), so the avatar's fallback initials/role would only add noise.
+      return <Avatar {...displayInfo} aria-hidden size='md' />;
+    };
+  }, [Avatar, entity, extractDisplayInfo]);
 
   if (!hasEntity) return null;
 

src/plugins/ChannelDetail/Views/ChannelMembersView/ChannelMembersAddView.tsx

@@ -72,7 +72,7 @@ const ChannelMembersAddViewItem = ({
       function MemberAvatar() {
         return <Avatar {...displayInfo} isOnline={user.online} size='md' />;
       },
-    [Avatar, displayInfo, user.online],
+    [Avatar, displayInfo, user],
   );
 
   const SelectableTrailingSlot = useMemo(