Skip to content

Commit 45e41ac

Browse files
committed
feat: remove FixedHeightMessage component
1 parent 58ec965 commit 45e41ac

4 files changed

Lines changed: 2 additions & 237 deletions

File tree

src/components/Gallery/decisions.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,14 @@ Following the project's established pattern of static imports with `propComponen
4949
The old `Gallery.tsx` contained a thumbnail grid + modal component (with `images` and `innerRefs` props). The new architecture separates this into a Gallery provider (carousel state) and ModalGallery (thumbnail grid + modal).
5050

5151
**Decision:**
52-
Replace the old Gallery.tsx content entirely with the new Gallery provider. The old Gallery functionality will be reimplemented as ModalGallery in Task 4. Downstream type errors in `AttachmentContainer.tsx` and `FixedHeightMessage.tsx` are expected and will be resolved in Tasks 4 and 8.
52+
Replace the old Gallery.tsx content entirely with the new Gallery provider. The old Gallery functionality will be reimplemented as ModalGallery in Task 4. Downstream type errors in `AttachmentContainer.tsx` are expected and will be resolved in Tasks 4 and 8.
5353

5454
**Reasoning:**
5555
The plan explicitly says "replace existing content" for Gallery.tsx. The old GalleryProps type (with `images`/`innerRefs`) is incompatible with the new GalleryProps (with `items`/`initialIndex`/`onIndexChange`/`GalleryUI`). A clean replacement is necessary.
5656

5757
**Tradeoffs / Consequences:**
5858

59-
- Temporary TypeScript errors in downstream consumers (`AttachmentContainer.tsx`, `FixedHeightMessage.tsx`) until Tasks 4 and 8 update them.
59+
- Temporary TypeScript errors in downstream consumers (`AttachmentContainer.tsx`) until Tasks 4 and 8 update them.
6060

6161
## Decision: GalleryUI defers loading/error states to BaseImage and native elements
6262

src/components/Message/FixedHeightMessage.tsx

Lines changed: 0 additions & 130 deletions
This file was deleted.

src/components/Message/__tests__/FixedHeightMessage.test.js

Lines changed: 0 additions & 104 deletions
This file was deleted.

src/components/Message/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
export * from './FixedHeightMessage';
21
export * from './hooks';
32
export * from './icons';
43
export * from './Message';

0 commit comments

Comments
 (0)