fix(InfiniteScroll): replace refs with state-based deps#2740
Merged
MartinCupela merged 1 commit intomasterfrom Jun 19, 2025
Merged
fix(InfiniteScroll): replace refs with state-based deps#2740MartinCupela merged 1 commit intomasterfrom
MartinCupela merged 1 commit intomasterfrom
Conversation
arnautov-anton
force-pushed
the
fix/message-list-initial-position
branch
from
0d47da1 to
d172488
Compare
|
Size Change: -138 B (-0.01%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2740 +/- ##
==========================================
- Coverage 81.34% 81.34% -0.01%
==========================================
Files 481 481
Lines 9541 9535 -6
Branches 2221 2219 -2
==========================================
- Hits 7761 7756 -5
Misses 1408 1408
+ Partials 372 371 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arnautov-anton
changed the title
arnautov-anton
commented
Jun 19, 2025
Comment on lines
+180
to
+184
| <Component {...elementProps} ref={setScrollComponent}> | ||
| {head} | ||
| {loader} | ||
| {children} | ||
| </Component> |
Contributor
Author
There was a problem hiding this comment.
When we switch tsconfig.json#jsx option to react-jsx this will be translated to the _jsx function and React won't have to be imported to this module.
MartinCupela
approved these changes
Jun 19, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
## [13.1.2](v13.1.1...v13.1.2) (2025-06-19) ### Bug Fixes * **InfiniteScroll:** replace refs with state-based deps ([#2740](#2740)) ([148db93](148db93))
|
🎉 This PR is included in version 13.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes an issue where
MessageListis loaded scrolled up to the seemingly random location and not at the bottom as it's supposed to be.Ref: https://getstream.slack.com/archives/C089TAPMPU0/p1750320899229359