fix: make character composition possible in textarea#2762
Merged
MartinCupela merged 2 commits intomasterfrom Jul 11, 2025
Merged
fix: make character composition possible in textarea#2762MartinCupela merged 2 commits intomasterfrom
MartinCupela merged 2 commits intomasterfrom
Conversation
|
Size Change: +285 B (+0.03%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
# Conflicts: # src/components/TextareaComposer/TextareaComposer.tsx
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2762 +/- ##
==========================================
+ Coverage 81.28% 81.36% +0.08%
==========================================
Files 479 479
Lines 9521 9525 +4
Branches 2215 2216 +1
==========================================
+ Hits 7739 7750 +11
+ Misses 1411 1403 -8
- Partials 371 372 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oliverlaz
approved these changes
Jul 11, 2025
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
## [13.2.2](v13.2.1...v13.2.2) (2025-07-11) ### Bug Fixes * change MultipleAnswersField input element to type text ([#2761](#2761)) ([a590629](a590629)) * distinguish non-submit form buttons ([#2769](#2769)) ([bdc3c3e](bdc3c3e)) * ensure all message links are properly wrapped when sharing same root domain ([#2754](#2754)) ([adeb0e7](adeb0e7)) * focus textarea upon file input change event ([#2752](#2752)) ([22e0702](22e0702)) * forward error object to LoadingErrorIndicator in ChannelList ([#2768](#2768)) ([c014b1f](c014b1f)) * keep focused textarea when message composer state changes ([#2759](#2759)) ([e6d5a7f](e6d5a7f)) * make character composition possible in textarea ([#2762](#2762)) ([bbe09e5](bbe09e5)) * prevent querying thread draft when drafts are disabled ([#2767](#2767)) ([ff43179](ff43179)) * prevent setting unread UI state for channel non-members ([#2757](#2757)) ([952612a](952612a))
|
🎉 This PR is included in version 13.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fix #2760
🛠 Implementation details
Controlling the textarea value via external state lead to cancellation of composition events - specifically
compositionend. But at the same time, we need to override the textarea value with the middleware processing result (e.g. to replace original string with emoji).So the value is set inside the effect.