Skip to content

fix: reset PollComposer state on poll creation form submission #2795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinCupela merged 2 commits into from
Aug 8, 2025
Merged

fix: reset PollComposer state on poll creation form submission #2795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d00d27
fix: reset PollComposer state on poll creation form submission
MartinCupela Aug 7, 2025
2cbba24
Merge branch 'master' into fix/init-poll-state-on-poll-form-submit
MartinCupela Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/Poll/PollCreationDialog/PollCreationDialogControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,10 @@ export const PollCreationDialogControls = ({
messageComposer
.createPoll()
.then(() => handleSubmitMessage())
.then(close)
.then(() => {
messageComposer.pollComposer.initState();
close();
})
.catch(console.error);
}}
type='submit'
Expand Down
16 changes: 15 additions & 1 deletion src/components/Poll/__tests__/PollCreationDialog.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,9 @@ describe('PollCreationDialog', () => {
const createPollSpy = jest
.spyOn(client, 'createPoll')
.mockImplementationOnce(() => Promise.resolve({ poll }));
const initPollStateSpy = jest
.spyOn(channel.messageComposer.pollComposer, 'initState')
.mockImplementation();

await act(async () => {
await fireEvent.change(getNameInput(), { target: { value: formState.name } });
Expand Down Expand Up @@ -407,14 +410,25 @@ describe('PollCreationDialog', () => {
expect.objectContaining(expectedPollPayload),
);
expect(close).toHaveBeenCalledTimes(1);
expect(initPollStateSpy).toHaveBeenCalledTimes(1);
});
});

it('closes the form on cancel', async () => {
await renderComponent();
const {
channels: [channel],
client,
} = await initClientWithChannels({ customUser: user });
const initPollStateSpy = jest
.spyOn(channel.messageComposer.pollComposer, 'initState')
.mockImplementation();

await renderComponent({ channel, client });

act(() => {
fireEvent.click(screen.getByText(CANCEL_BUTTON_TEXT));
});
expect(close).toHaveBeenCalledTimes(1);
expect(initPollStateSpy).toHaveBeenCalledTimes(1);
});
});