Skip to content

fix: remove optimization preventing ChannelList re-render on member.updated event #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinCupela merged 1 commit into from
Aug 18, 2025
Merged

fix: remove optimization preventing ChannelList re-render on member.updated event #2801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/components/ChannelList/hooks/useChannelListShape.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,11 +314,6 @@ export const useChannelListShapeDefaults = () => {
const newTargetChannelIndex =
typeof lastPinnedChannelIndex === 'number' ? lastPinnedChannelIndex + 1 : 0;

// skip re-render if the position of the channel does not change
if (currentChannels[newTargetChannelIndex] === targetChannel) {
return currentChannels;
}

newChannels.splice(newTargetChannelIndex, 0, targetChannel);

return newChannels;
Expand Down