fix: prevent textarea selection reset upon text insertion#2814
Merged
MartinCupela merged 2 commits intomasterfrom Sep 3, 2025
Merged
fix: prevent textarea selection reset upon text insertion#2814MartinCupela merged 2 commits intomasterfrom
MartinCupela merged 2 commits intomasterfrom
Conversation
|
Size Change: -99 B (-0.01%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Sep 2, 2025
|
🎉 This PR is included in version 13.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes #2813
Closes REACT-550
🛠 Implementation details
The jumping was caused by setting the textarea value in the effect after the textarea selection range was set. This was interpreted by the browser as a reset leading to the change of selection to the end of the textarea.
Future improvements
Setting textarea selection start and end in effects leads also to breaking the undo history maintained by the browser.
As the text is processed async using middleware, we cannot rely on native undo history support. We can add history API to TextComposer to keep certain amount of TextComposer state snapshots and when Cmd(Ctrl) + Z / F is pressed we could do textComposer.undo() / textComposer.redo().
depends on: GetStream/stream-chat-js#1608