Conversation
- Bump codecov/codecov-action v5 → v6 (adds Node 24 support) - Pin Node 24 in size workflow via setup-node + node-version-file: .nvmrc - Drop YARN_IGNORE_ENGINES workaround in size workflow (no longer needed) - Composite setup-node action now reads node-version-file: .nvmrc as single source of truth
|
Size Change: 0 B Total Size: 672 kB ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3156 +/- ##
=======================================
Coverage 82.79% 82.79%
=======================================
Files 419 419
Lines 12270 12270
Branches 3951 3951
=======================================
Hits 10159 10159
Misses 2111 2111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MartinCupela
approved these changes
Apr 30, 2026
|
🎉 This PR is included in version 14.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Keep our CI pipeline current and remove drift between the Node version we develop against and the one CI runs. Specifically:
codecov/codecov-actionwas onv5;v6(Mar 2026) is the first major with Node 24 support, matching the rest of our toolchain.'24'in two places (the compositesetup-nodeaction and the size workflow), so a future Node bump would require touching multiple files in lockstep with.nvmrc. Single source of truth is safer.preactjs/compressed-size-actiondefaults to (Node 20), forcing us to setYARN_IGNORE_ENGINES: 'true'to bypass ourenginesrequirement. That's a workaround that masks the actual problem — the job wasn't running on Node 24.🛠 Implementation details
.github/actions/setup-node/action.ymlnode-versioninput (no caller was overriding it) and switchedactions/setup-node@v6tonode-version-file: '.nvmrc'..nvmrcis now the single source of truth for the Node version across all workflows that use this composite action..github/workflows/ci.ymlcodecov/codecov-actionfromv5→v6..github/workflows/size.ymlactions/setup-node@v6step (also usingnode-version-file: '.nvmrc') beforepreactjs/compressed-size-action@v2, so the job's shell commands run under Node 24.YARN_IGNORE_ENGINES: 'true'env override now that the engines requirement is satisfied.Audit notes (no changes needed)
actions/checkout@v6,actions/setup-node@v6,actions/cache@v5,preactjs/compressed-size-action@v2.🎨 UI Changes
N/A — CI/build configuration only, no runtime or visual changes.